Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(loki): simplesort leverages binary indices better when filtered #83

Merged
merged 1 commit into from
Mar 19, 2018

Conversation

Viatorus
Copy link
Member

array intersection algorithm is used to leverage binary index on simplesort if you have filtered out at least 10% of total documents from results

See techfort/LokiJS@4e28e81

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@coveralls
Copy link

coveralls commented Mar 14, 2018

Coverage Status

Coverage increased (+0.06%) to 92.096% when pulling a78c070 on feature/simplesort_binary_index into fdf1c62 on master.

@Viatorus Viatorus force-pushed the feature/simplesort_binary_index branch 5 times, most recently from b1ae56b to 3f2cbff Compare March 19, 2018 20:39
array intersection algorithm is used to leverage binary index on simplesort if the filtered documents is a least 10% of total documents from results

See techfort/LokiJS@4e28e81
@Viatorus Viatorus force-pushed the feature/simplesort_binary_index branch from 3f2cbff to a78c070 Compare March 19, 2018 21:11
@Viatorus Viatorus merged commit 4d1b25b into master Mar 19, 2018
@Viatorus Viatorus deleted the feature/simplesort_binary_index branch March 19, 2018 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants