Check Spelling annotations not collapsing (OSOE-525)

[Piedone]

Lately, the PR annotations of Check Spelling are not collapsing after the spelling errors are fixed, see e.g. here. These should rather look like this after the errors have been resolved (note "This comment has been minimized.", I opened it):

I suspect this is because of the longer advice configured. If indeed, then we should rather have a short advice.md that links to a longer documentation page.

Jira issue

[BenedekFarkas]

Same thing with the short version that links the one in this repo. Maybe the logic here is that having an advice.md means you want to keep it shown all the time or IDK.

[Piedone]

What are you referring to, exactly? The screenshot I've include above uses advice.md but a shorter version, and it properly got collapsed.

[BenedekFarkas]

That one! In DotNest Core Sites SDK for example (and at least one more repo I worked on this week), the last failure report wasn't collapsed after an error-free commit. I thought it's just GH having hiccups (it's been behaving strangely in the past week or so), so I collapsed it manually.

[Piedone]

In a private repo, you've shown this:

The difference is that it refers to the comment being hidden as opposed to minimized. I've checked out older PRs and what seems to be the one that Check Spelling does is the "minimized" one (was the "hidden" one hidden manually?). So, as shown from this, indeed simply the shorter advice doesn't solve this (but having an advice is not a problem, the screenshot in the issue description shows that).

[Piedone]

Hmm, this comment is properly collapsed (with a long advice, with "minimized") and was added at 11:48 PM CET on 4 January. This comment under the same PR isn't, and it was created at 3:37 PM CET on 5 January. Between these only this commit happened but that shouldn't cause it. Also, this uncollapsed comment was added on 3 January, so it's not related to some changes we made.

[Piedone]

Opened a bug report: check-spelling/check-spelling#44

[BenedekFarkas]

That's right, minimized is the automatic, hidden is manual one.

[Piedone]

See from check-spelling/check-spelling#44 (comment). We need to change our implementation according to this.

[Piedone]

Fixed in #205.