OSOE-525: Collapse spelling annotation #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored Spelling action to pass additional inputs to spell-check-this. Refactored Check Spelling workflow into two jobs. Each job passes input parameters to support check-spellings 2 stage design.
|
FYI, this PR is not ready to merge even though "All the checks have passed" - the reason is that the spelling-this-repo.yml workflow file is invalid (I accidentally broke it in this branch). I wonder if there is a way to mark the PR as failed when there are invalid workflows. |
|
It's okay, nobody will merge it or review it until it is not requested. Don't worry about that! |
Simplify earlier approach by removing unneccesary inputs from reusable spelling workflow. Remove prior changes to workflow that spell checks this repository. Add 2nd job that calls check-spelling action to perform followup task of commenting or collapsing prior comment on pull requests. The check-spelling/check-spelling's design assumes two separate jobs. The first job does the spelling checking, uploads the comment as an artifact, then outputs a follow task to either comment or collapse prior comment on PR. The second job performs the followup task. This allows different permissions to be set for each job.
This comment has been minimized.
This comment has been minimized.
…e brach for actions
This comment has been minimized.
This comment has been minimized.
|
Excellent - successfully commented and then subsequently collapsed the spelling annotations on this PR |
wAsnk
requested changes
Feb 15, 2023
wAsnk
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSOE-525