GOV-1: Adding warning-as-error option for build related actions and workflows

.github/actions/build-dotnet/Build-DotNetSolutionOrProject.ps1

@@ -1,12 +1,13 @@
-param (
+param (
     [string] $Configuration,
     [string] $SolutionOrProject,
     [string] $Verbosity,
     [string] $EnableCodeAnalysis,
     [string] $Version,
     [string] $Switches,
     [string] $ExpectedCodeAnalysisErrors,
-    [boolean] $CreateBinaryLog)
+    [boolean] $CreateBinaryLog,
+    [boolean] $WarningsAsErrors)
 
 function ConvertTo-Array([string] $rawInput)
 {
@@ -24,10 +25,10 @@ $buildSwitches = ConvertTo-Array @"
     --configuration:$Configuration
     --nologo
     --verbosity:$Verbosity
-    --warnaserror
+    $($WarningsAsErrors ? '--warnaserror' : '')
     --warnAsMessage:MSB3026
     --consoleLoggerParameters:NoSummary
-    -p:TreatWarningsAsErrors=true
+    -p:TreatWarningsAsErrors=$WarningsAsErrors
     -p:RunAnalyzersDuringBuild=$EnableCodeAnalysis
     -p:Retries=4
     -p:RetryDelayMilliseconds=1000

.github/actions/build-dotnet/action.yml

@@ -76,6 +76,14 @@ inputs:
     description: >
       Duration in days after which the artifact of the binary log (if any) will expire. See
       https://github.com/actions/upload-artifact#retention-period for more details.
+  warnings-as-errors:
+    required: false
+    default: "true"
+    description: >
+      Whether compiler warnings should be treated as errors during the build process. The default value is "true", the
+      compiler flag "-warnaserror" will be used, causing the build to fail if any warnings are generated. If set to
+      "false", the flag "-warnaserror" will not be used, allowing warnings to be generated without causing the build to
+      fail.
 
 runs:
   using: "composite"
@@ -158,6 +166,7 @@ runs:
             Switches = $buildSwitches
             ExpectedCodeAnalysisErrors = $expectedCodeAnalysisErrors
             CreateBinaryLog = $${{ inputs.create-binary-log }}
+            WarningsAsErrors = $${{ inputs.warnings-as-errors }}
         }
 
         $startTime = [DateTime]::Now

.github/workflows/build-and-test-dotnet.yml

@@ -123,6 +123,15 @@ on:
         description: >
           When set to true, it will be verified whether the NuGet packages of the .NET solution are consolidated, i.e.
           the same version of a given package is used in all projects.
+      warnings-as-errors:
+        required: false
+        type: string
+        default: "true"
+        description: >
+          Whether compiler warnings should be treated as errors during the build process. The default value is "true",
+          the compiler flag "-warnaserror" will be used, causing the build to fail if any warnings are generated. If set
+          to "false", the flag "-warnaserror" will not be used, allowing warnings to be generated without causing the
+          build to fail.
 
 jobs:
   # While the below steps seem suitable to DRY with build-and-test-orchard-core, since reusable workflows can't call
@@ -169,6 +178,7 @@ jobs:
           solution-or-project-path: ${{ inputs.build-solution-path }}
           create-binary-log: ${{ inputs.build-create-binary-log }}
           binary-log-artifact-retention-days: ${{ inputs.build-binary-log-artifact-retention-days }}
+          warnings-as-errors: ${{ inputs.warnings-as-errors }}
 
       - name: Tests
         if: inputs.test-disable == 'false'

.github/workflows/build-and-test-orchard-core.yml

@@ -153,6 +153,15 @@ on:
         description: >
           When set to true, it will be verified whether the NuGet packages of the .NET solution are consolidated, i.e.
           the same version of a given package is used in all projects.
+      warnings-as-errors:
+        required: false
+        type: string
+        default: "true"
+        description: >
+          Whether compiler warnings should be treated as errors during the build process. The default value is "true",
+          the compiler flag "-warnaserror" will be used, causing the build to fail if any warnings are generated. If set
+          to "false", the flag "-warnaserror" will not be used, allowing warnings to be generated without causing the
+          build to fail.
 
 jobs:
   build-and-test:
@@ -199,6 +208,7 @@ jobs:
           solution-or-project-path: ${{ inputs.build-solution-path }}
           create-binary-log: ${{ inputs.build-create-binary-log }}
           binary-log-artifact-retention-days: ${{ inputs.build-binary-log-artifact-retention-days }}
+          warnings-as-errors: ${{ inputs.warnings-as-errors }}
 
       - name: Set up SQL Server
         if: inputs.set-up-sql-server == 'true'