Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSOE-566: Fixing that the publish-nuget workflow doesn't fail when a package build has an error #222

Merged
merged 8 commits into from
Mar 31, 2023
Merged

OSOE-566: Fixing that the publish-nuget workflow doesn't fail when a package build has an error #222

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8fd27da
Not pushing to NuGet temporarily in publish-nuget to test error handling
Piedone Mar 30, 2023
ae456d9
Failing NuGet publishing if pack fails
Piedone Mar 30, 2023
8bd610d
Revert "Not pushing to NuGet temporarily in publish-nuget to test err…
Piedone Mar 30, 2023
62957fa
Using an error annotation for the output instead
Piedone Mar 31, 2023
d381710
Now keeping Write-Error
Piedone Mar 31, 2023
1a5b8e7
Not pushing to NuGet temporarily in publish-nuget to test error handling
Piedone Mar 31, 2023
0d7cb31
Revert "Now keeping Write-Error"
Piedone Mar 31, 2023
da1771e
Revert "Not pushing to NuGet temporarily in publish-nuget to test err…
Piedone Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/actions/publish-nuget/New-NuGetPackage.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<#
<#
.SYNOPSIS
Creates a NuGet package from each project in the sln file in the current directory.
.DESCRIPTION
Expand Down Expand Up @@ -32,5 +32,11 @@ foreach ($project in $projects)
dotnet pack $project @Arguments
}

if ($LASTEXITCODE -ne 0)
{
Write-Output "::error::dotnet pack failed for the project $($project.FullName)."
exit 1
}

Pop-Location
}