OSOE-150: Fix Powershell code #23

sarahelsaig · 2022-07-05T08:09:34Z

OSOE-150

.github/actions/publish-nuget/New-NugetPackages.ps1

.github/actions/build-dotnet/action.yml

This reverts commit 4ed72df.

This reverts commit f8b5442.

# Conflicts: # .github/actions/setup-edge-linux/Initialize-Edge.ps1 # .github/actions/setup-edge-linux/action.yml

.github/workflows/test-analysis-failure.yml

.github/actions/build-dotnet/Build-DotNetSolution.ps1

sarahelsaig added 2 commits July 4, 2022 04:59

Clean up ps1 in setup-edge-linux.

d0bc1d6

Copy New-New-NugetPackages from issue/OSOE-110

6b19f34

sarahelsaig mentioned this pull request Jul 5, 2022

OSOE-150: ⭐ Add PowerShell static code analysis to OSOCE Lombiq/Open-Source-Orchard-Core-Extensions#149

Merged

sarahelsaig added 12 commits July 5, 2022 12:41

Run ps1 linting in build-dotnet.

020ad85

Fix typo.

e14d80d

Fix missing input usage.

4b5fdd2

Make pwsh linting a separate step.

b825efe

bug fix

591c9a6

Without hashFiles.

f6e4364

Fix warnings in ps1 files.

bb98f03

Rename scripts to use cmdlet style names with approved verbs.

3ae2793

Add dotnet-pack-ignore-warning option to pack.

5ca2508

Fix indentation.

957bdd5

Merge remote-tracking branch 'origin/dev' into issue/OSOE-150

e0d2425

Fix readme title capitalization.

a154ea9

Piedone requested changes Jul 6, 2022

View reviewed changes

.github/actions/publish-nuget/New-NugetPackages.ps1 Outdated Show resolved Hide resolved

.github/actions/build-dotnet/action.yml Outdated Show resolved Hide resolved

.github/actions/build-dotnet/action.yml Outdated Show resolved Hide resolved

sarahelsaig added 14 commits July 10, 2022 19:44

Remove this for now.

b14e882

Remove PS analyzer invocation.

4ed72df

Revert "Remove PS analyzer invocation."

f8b5442

This reverts commit 4ed72df.

Revert "Revert "Remove PS analyzer invocation.""

c9d14f0

This reverts commit f8b5442.

Convert MSBuild errors into GH errors.

b11003f

Merge remote-tracking branch 'origin/dev' into issue/OSOE-150

2b85d96

# Conflicts: # .github/actions/setup-edge-linux/Initialize-Edge.ps1 # .github/actions/setup-edge-linux/action.yml

Merge remote-tracking branch 'origin/dev' into issue/OSOE-150

d9265af

Add test-analysis-failure workflow.

08bc1e8

Remove unexpected prop.

13f0e2c

Order doesn't matter.

5c6c29c

Use Warning.

79848e8

Only test at the end.

c25a7ef

Don't overwrite variable.

1c5f55b

Add comments.

1dcb025

sarahelsaig added 15 commits July 16, 2022 16:41

Exit zero on success (duh).

c5ce253

Try to ignore dotnet build's exit code.

a4887ea

Clearing exit code

463d6cf

Temporary diagnostics.

9ffcfd8

Write out full command.

c09f5f5

No idea what's going on here.

0f174e2

don't use the word "output"

ec5e990

fix path

a13f87d

why

2d518a9

i cri everydai

59a250a

I have no idea what's going on.

c688e0a

Use Get-Content instead of ReadAllLines.

093aa23

is foreach evil?

f455047

Remove diagnostics.

148aa4a

simplify

6344a84

Piedone requested changes Jul 19, 2022

View reviewed changes

sarahelsaig added 2 commits July 20, 2022 02:18

Reformat.

ffc26b7

Compiled regex.

107b93b

Piedone approved these changes Jul 20, 2022

View reviewed changes

Piedone merged commit e2841ae into dev Jul 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OSOE-150: Fix Powershell code #23

OSOE-150: Fix Powershell code #23

sarahelsaig commented Jul 5, 2022

OSOE-150: Fix Powershell code #23

OSOE-150: Fix Powershell code #23

Conversation

sarahelsaig commented Jul 5, 2022