Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSOE-729: Prevent Azure-related workflows running at the same time when interacting with the same environment(s) #287

Merged
merged 13 commits into from
Nov 29, 2023

Conversation

BenedekFarkas
Copy link
Member

@BenedekFarkas BenedekFarkas commented Nov 24, 2023

OSOE-729
Fixes #281

@BenedekFarkas BenedekFarkas self-assigned this Nov 24, 2023
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only content change in this file is the categories section.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks incoming links (we also have those in our wiki). This is necessary, but at that point, let's make it future proof: put all the workflows' docs into their own pages, and then you can elevate the content of this page (with the general notes and links to workflows' pages) to the Readme, so people have to dig less.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me after the refactoring but I @Piedone please approve if you are fine as its your request.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not fine, hence my comment :).

Copy link
Contributor

@Psichorex Psichorex Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait didn't this got addressed by the factored out .mds?
Edit: I see now, my brain got stuck at the new .mds.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. The link in the Readme is broken BTW.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I noticed, went around just now and checked/fixed every link.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the links seems to be fine, at least on my side so probably overall aswell. Went throught manually on most of them and I yet to find any broken ones.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I noticed, went around just now and checked/fixed every link.

From this reply I thought that all links are fine now but for me SpellChecking.md has broken links.
https://github.com/Lombiq/GitHub-Actions/blob/763adec7ca1b54e16985554d97b88b253196b96f/Docs/Workflows/Productivity/SpellChecking.md#:~:text=proxied%20by%20the-,spelling%20action,-in%20this%20repository

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@Psichorex
Copy link
Contributor

I will merge if @Piedone approves. Everything seems fine. Approved by me.

@Piedone
Copy link
Member

Piedone commented Nov 28, 2023

It's only up to you.

@Psichorex
Copy link
Contributor

It's only up to you.

I asked because you had an unresolved comment containing a request for which I didn't see a clear indication that it was resolved.

@Piedone
Copy link
Member

Piedone commented Nov 29, 2023

I understand, but it's still up to you, me doing a second review of this PR is unnecessary.

@Psichorex Psichorex added this pull request to the merge queue Nov 29, 2023
Merged via the queue into dev with commit 4a8d8b4 Nov 29, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants