-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSOE-729: Prevent Azure-related workflows running at the same time when interacting with the same environment(s) #287
Conversation
… the app name instead of the workflow's name
Docs/Workflows/Index.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only content change in this file is the categories section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks incoming links (we also have those in our wiki). This is necessary, but at that point, let's make it future proof: put all the workflows' docs into their own pages, and then you can elevate the content of this page (with the general notes and links to workflows' pages) to the Readme, so people have to dig less.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me after the refactoring but I @Piedone please approve if you are fine as its your request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not fine, hence my comment :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait didn't this got addressed by the factored out .mds?
Edit: I see now, my brain got stuck at the new .mds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good. The link in the Readme is broken BTW.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I noticed, went around just now and checked/fixed every link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the links seems to be fine, at least on my side so probably overall aswell. Went throught manually on most of them and I yet to find any broken ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I noticed, went around just now and checked/fixed every link.
From this reply I thought that all links are fine now but for me SpellChecking.md has broken links.
https://github.com/Lombiq/GitHub-Actions/blob/763adec7ca1b54e16985554d97b88b253196b96f/Docs/Workflows/Productivity/SpellChecking.md#:~:text=proxied%20by%20the-,spelling%20action,-in%20this%20repository
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
I will merge if @Piedone approves. Everything seems fine. Approved by me. |
It's only up to you. |
I asked because you had an unresolved comment containing a request for which I didn't see a clear indication that it was resolved. |
I understand, but it's still up to you, me doing a second review of this PR is unnecessary. |
…nfiguration.md relative instead of absolute
OSOE-729
Fixes #281