Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert-235: OSOE-464: Executing dotnet test with process timeout #305

Conversation

dministro
Copy link
Member

@dministro dministro commented Jan 14, 2024

Copy link
Contributor

coderabbitai bot commented Jan 14, 2024

Walkthrough

Walkthrough

The recent updates across various scripts and workflow files indicate a simplification of the testing process for .NET solutions. The removal of the TestProcessTimeout parameter suggests a shift away from custom timeout handling. Refactoring of the connection string construction indicates an optimization in database connectivity. The replacement of a custom process management function with a direct dotnet test command implies a move towards more standard testing practices. This is complemented by the removal of tooling and artifacts related to diagnosing test hangs.

Changes

File Path Change Summary
.github/actions/test-dotnet/Invoke-SolutionTests.ps1 Removed $TestProcessTimeout, refactored $connectionString, replaced StartProcessAndWaitForExit
.github/actions/test-dotnet/action.yml Removed dotnet-test-process-timeout, dotnet-dump installation, and DotnetTestHangDumps upload
.github/workflows/*.yml Removed dotnet-test-process-timeout parameter from workflow files

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions github-actions bot changed the title Revert "OSOE-464: Executing dotnet test with process timeout" revert-235: Revert "OSOE-464: Executing dotnet test with process timeout" Jan 14, 2024
@dministro dministro changed the title revert-235: Revert "OSOE-464: Executing dotnet test with process timeout" OSOE-464: Revert: Executing dotnet test with process timeout Jan 14, 2024
@dministro dministro closed this Jan 14, 2024
@dministro dministro reopened this Jan 14, 2024
@dministro dministro changed the title OSOE-464: Revert: Executing dotnet test with process timeout Revert-235: OSOE-464: Executing dotnet test with process timeout Jan 14, 2024
@dministro dministro changed the title Revert-235: OSOE-464: Executing dotnet test with process timeout revert-235: OSOE-464: Executing dotnet test with process timeout Jan 14, 2024
@dministro dministro added this pull request to the merge queue Jan 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 14, 2024
@sarahelsaig sarahelsaig enabled auto-merge January 14, 2024 22:29
@sarahelsaig sarahelsaig added this pull request to the merge queue Jan 14, 2024
Merged via the queue into dev with commit 5230690 Jan 14, 2024
dministro added a commit that referenced this pull request Jan 21, 2024
…executing-dotnet-test-with-process-timeout"

Fixing errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants