Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSOE-796: Fix setup-sql-server GitHub Windows Larger Runner incompatibility in Lombiq.GitHub.Actions #321

Merged
merged 15 commits into from
Feb 14, 2024

Conversation

Psichorex
Copy link
Contributor

@Psichorex Psichorex commented Feb 6, 2024

OSOE-796
Fixes #320

Copy link
Contributor

coderabbitai bot commented Feb 6, 2024

Walkthrough

The overall change focuses on addressing a specific issue with SQL Server installation on GitHub-hosted Windows Larger Runners, which failed due to a pending system reboot requirement. To resolve this, updates were made to PowerShell scripts and GitHub Actions workflows to specify SQL Server versions and adjust connection strings, alongside changing references to a specific issue branch to ensure compatibility and successful SQL Server setup within CI environments.

Changes

Files Change Summary
.github/actions/setup-sql-server/.../Initialize-SqlServer.ps1
.github/actions/test-dotnet/.../Invoke-SolutionTests.ps1
Updated SQL Server installation command and connection string for compatibility with specific versions and environments.
.github/workflows/.../build-and-test-dotnet.yml
.github/workflows/.../build-and-test-orchard-core.yml
.github/workflows/.../msbuild-and-test.yml
Updated references to the test-dotnet action and GitHub Actions setup for SQL Server to use the issue/OSOE-796 branch.

Assessment against linked issues

Objective Addressed Explanation
Investigate the issue within Chocolatey or script (OSOE-796) The changes address the system reboot issue but do not explicitly mention investigations into Chocolatey or script modifications to bypass the reboot requirement.
Update configuration for build-and-test-larger-runners job (OSOE-796) The summary lacks direct mention of updates to the build-and-test-larger-runners job configuration as required by the linked issue.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions github-actions bot changed the title Fix setup-sql-server GitHub Windows Larger Runner incompatibility in Lombiq.GitHub.Actions OSOE-796: Fix setup-sql-server GitHub Windows Larger Runner incompatibility in Lombiq.GitHub.Actions Feb 6, 2024
Psichorex and others added 3 commits February 6, 2024 21:31
Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
@Piedone Piedone added this pull request to the merge queue Feb 14, 2024
Merged via the queue into dev with commit d3fcbab Feb 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix setup-sql-server GitHub Windows Larger Runner incompatibility (OSOE-796)
3 participants