OSOE-874: Build and Static Code Analysis not showing the offending file and line for submodules #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
sarahelsaig
approved these changes
Jul 3, 2024
Cool, but now I can't merge it in using auto-merge. Please do it manually. |
|
I instead fixed the bug, was easy enough. Example of it working correctly: https://github.com/Lombiq/GitHub-Actions/actions/runs/9780745061/job/27003131801?pr=366 If you approve, I'll still need to disable the branch protection rule temporarily to merge it. |
sarahelsaig
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSOE-874
Fixes #365
Note to reviewer:
This:
Under Validate GitHub Actions Refs is a fluke of the validation logic that somehow apparently trips on a changed gitignore. It's not something that needs to be fixed.
Example showing proper errors, though neither PR diff annotations, nor errors listed in the workflow summary. This also works with submodules, see here.