OSOE-466: Configuration option to filter tests #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahelsaig
requested changes
Nov 12, 2022
Comment on lines
47
to
48
| [string]::IsNullOrEmpty($Filter) ? '' : "--filter" | ||
| [string]::IsNullOrEmpty($Filter) ? '' : $Filter |
There was a problem hiding this comment.
[string]::IsNullOrEmpty is redundant, also the string quotes are inconsistent.
Suggested change
| [string]::IsNullOrEmpty($Filter) ? '' : "--filter" | |
| [string]::IsNullOrEmpty($Filter) ? '' : $Filter | |
| $Filter ? "" : "--filter" | |
| $Filter ? "" : $Filter |
There was a problem hiding this comment.
All of them should actually be single quote (since we don't need string interpolation).
There was a problem hiding this comment.
It's not really working as expected:
I'm reverting to the original code
There was a problem hiding this comment.
Yeah, the ternary's components should be the other way around, since "truthy" implies that it's not null or empty.
Co-authored-by: Dávid El-Saig <david.el-saig@lombiq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSOE-466