Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSOE-744: Upgrade markdownlint to v.0.34.0 #99

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Conversation

BenedekFarkas
Copy link
Member

@BenedekFarkas BenedekFarkas commented May 24, 2024

OSOE-744

Note: See the explanation for the comments added here.

@@ -1,3 +1,4 @@
// When updating, also update the same configuration file accompanying the "markdown-lint" action in Lombiq.GitHub.Actions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this works? Last time I checked .markdownlint.json has to be a standard JSON file (meaning it has to work when passed into JSON.parse() in Javascript), so comments will break the parser.

Lombiq.NodeJs.Extensions/package.json Outdated Show resolved Hide resolved
…ting the "markdown-lint" action in Lombiq.GitHub.Actions too"

This reverts commit 55bf03c.
@sarahelsaig sarahelsaig merged commit 9ff5886 into dev Jun 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants