Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LMBQ-144: Moving migrations recipe to the Migrations folder to prevent exception when deployed #76

Merged
merged 4 commits into from
Jun 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,4 @@ bin/
wwwroot
node_modules
.pnpm-debug.log
/Lombiq.BaseTheme/Migrations/Lombiq.BaseTheme.LayersAndZones.recipe.json
*.orig
1 change: 0 additions & 1 deletion Lombiq.BaseTheme.Samples/Manifest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
// - Reference the project in your web app.
// - Enable the "Lombiq.BaseTheme.Samples" feature in your setup recipe.
// - Set the site theme to "Lombiq.BaseTheme.Samples" in your setup recipe.
// - Run the "Lombiq.BaseTheme.LayersAndZones" recipe from your setup recipe.
// You can see these in the "Lombiq.OSOCE.Web.csproj" and the "Lombiq.OSOCE.Tests.recipe.json" files in the
// https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/ repository.

Expand Down
6 changes: 0 additions & 6 deletions Lombiq.BaseTheme/Lombiq.BaseTheme.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,4 @@

<Import Condition="'$(NuGetBuild)' != 'true'" Project="..\..\..\Utilities\Lombiq.NodeJs.Extensions\Lombiq.NodeJs.Extensions\Lombiq.NodeJs.Extensions.targets" />

<!-- This is necessary, because if we try to invoke the recipe from the migration file using the "recipe" step it will
load forever and eventually cause a timeout. -->
<Target Name="Copy LayersAndZones to Migrations" AfterTargets="AfterResolveReferences">
<Copy SourceFiles="$(ProjectDir)Recipes\Lombiq.BaseTheme.LayersAndZones.recipe.json" DestinationFiles="$(ProjectDir)Migrations\Lombiq.BaseTheme.LayersAndZones.recipe.json" SkipUnchangedFiles="true" />
</Target>

</Project>
2 changes: 1 addition & 1 deletion Readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Besides the style and layout, the theme also automatically includes a minimalist

## Recipes

- Lombiq Orchard Core Base Theme - Layers and Zones: Call this if you plan on using widgets. It sets up all the supported zones and some common layers.
- Lombiq Orchard Core Base Theme - Layers and Zones: Sets up all the supported zones and some common layers. Automatically executed when you first enable the theme.
- Lombiq Orchard Core Base Theme - Styling Demo: Creates a Demo Page that can be helpful to see how your theme's stylesheet behaves on various HTML elements.

## Contributing and support
Expand Down