Fix issue with scheme url starting with emoji #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
https://github.com/Loomly/calendy/issues/9712
Brief Summary of Issue
Schema urls are being truncated when there's an emoji right next to the beginning of the url without any spaces like:
👍https://www.loomly.com
Details about Solution Chosen
The fix here was basically some smaller changes to
src/parser/uri-utils.tsto allow any character, including emojis, to start a schema url.NOTE: I also opened gregjacobs#408 upstream so we should be good to go with the original library as soon as that one is merged.
NOTE 2: I've opened originally #1 and am using that in the calendy branch for now due to some build issues I've faced related to pupeteer and npm packages. But this new PR only have the necessary changes I did to make the fix work.