Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/check minknow #351

Merged
merged 13 commits into from
May 7, 2024
Merged

Feature/check minknow #351

merged 13 commits into from
May 7, 2024

Commits on Apr 24, 2024

  1. Initial validation of minknow version and guppy dorado versions

    @mattloose
    mattloose committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    b304eb8 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. MinKNOW compatibility check function 

    Base-caller compatibiity check
    @Adoni5
    Adoni5 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    40760a8 View commit details
    Browse the repository at this point in the history

  2. Compatibility checks

    @Adoni5
    Adoni5 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    4298da9 View commit details
    Browse the repository at this point in the history

  3. Remove rogue comment

    @Adoni5
    Adoni5 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    246e69c View commit details
    Browse the repository at this point in the history

  4. edit insanely long string multiline string example fo sub tags

    @Adoni5
    Adoni5 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    46a3d9e View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Local updates

    @mattloose
    mattloose committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    d46b53b View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Error checking and minor corrections to address compatibility. We no … 

    …longer raiseException when a version issue is encountered. This means that readfish will continue to function with future versions of minKNOW if compatible.
    @mattloose
    mattloose committed May 3, 2024
    Configuration menu
    Copy the full SHA
    69b2c75 View commit details
    Browse the repository at this point in the history

  2. Error checking and minor corrections to address compatibility. We no … 

    …longer raiseException when a version issue is encountered. This means that readfish will continue to function with future versions of minKNOW if compatible.
    @mattloose
    mattloose committed May 3, 2024
    Configuration menu
    Copy the full SHA
    3571012 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Add default when popping sample_rate from guppy params 

    Prevents `KeyError` from being raised if `sample_rate`isn't listed as a `kwarg`
    @Adoni5
    Adoni5 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    d56042a View commit details
    Browse the repository at this point in the history

  2. Remove unused basecaller compatibilty function 

    We now just check in `dorado.py` and warn if there is a mismatch
    @Adoni5
    Adoni5 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    6cb85e3 View commit details
    Browse the repository at this point in the history

  3. Correct docstring, add doctests

    @Adoni5
    Adoni5 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    dc6644c View commit details
    Browse the repository at this point in the history

  4. Add more complete docstring to DIRECTION enum 

    Only return Enum variant from `check_compatibility`, not tuple of (bool, variant)
    @Adoni5
    Adoni5 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    aaebfca View commit details
    Browse the repository at this point in the history

  5. Suggest opening an issue if a suitable version of readfish doesn't exist

    @Adoni5
    Adoni5 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    8fec91e View commit details
    Browse the repository at this point in the history