Update reflect.go #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of 1.22 minimum tls version by default is now 1.2, but the test didn't specify lower one, even though they are testing exactly that.
…fana#3813) * Introduce a `k6 cloud run` command Important notice: this commit declare a cobra sub-command holding the logic for the `k6 cloud run` sub-command, but does not register it. In this commit, we duplicate the logic from the existing `k6 cloud` logic, with very little adjustments, to support the later registry of the `k6 cloud run` command. To simplify the collaboration on this and further reviews, we delegate any refactoring of the original cloud command's logic, to a further commit or Pull Request. * Introduce a `k6 cloud login` command Important notice: this commit declare a cobra sub-command holding the logic for the `k6 cloud login` sub-command, but does not register it. In this commit, we duplicate the logic from the existing `k6 login` logic, with very little adjustments, to support the later registry of the `k6 cloud login` command. To simplify the collaboration on this and further reviews, we delegate any refactoring of the original cloud command's logic, to a further commit or Pull Request. This new `k6 cloud login` command is notably focusing solely on authenticating with the Grafana Cloud k6, and by design does not aim to support InfluxDB authentication. * Register run and login subcommands of the cloud command * Add deprecation warning to k6 login and k6 login cloud commands * FIXME add tests assert k6 cloud run command's arguments handling * Apply Pull-Request suggestions Co-authored-by: Joan López de la Franca Beltran <5459617+joanlopez@users.noreply.github.com> * Improve cloud commands missing arguments handling * Apply suggestions from code review * Refactor cloud run command and tests to leverage existing code * Apply suggestions from code review Co-authored-by: Oleg Bespalov <oleg.bespalov@grafana.com> * fix lint of cmd package --------- Co-authored-by: Joan López de la Franca Beltran <5459617+joanlopez@users.noreply.github.com> Co-authored-by: Oleg Bespalov <oleg.bespalov@grafana.com>
Bumps [github.com/grafana/xk6-browser](https://github.com/grafana/xk6-browser) from 1.6.1-0.20240701105714-29f6ef3049fe to 1.7.0. - [Release notes](https://github.com/grafana/xk6-browser/releases) - [Commits](https://github.com/grafana/xk6-browser/commits/v1.7.0) --- updated-dependencies: - dependency-name: github.com/grafana/xk6-browser dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Lordnibbler
force-pushed
the
Lordnibbler-patch-1
branch
from
8fd47c1
to
ecfe844
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add call to
AllowMissingFileDescriptorsinlib/netext/grpcext/reflect.go.Why?
When this option is enabled, the reflection service will tolerate the absence of certain file descriptors. This means that if a file descriptor is missing, the reflection service will still attempt to provide information about available services and methods, albeit potentially incomplete.
For context as to why we want this fix, we are experiencing similar issues to the issues reported by grpcurl in this issue: fullstorydev/grpcurl#453, and noted after grpcurl 1.9.0 was released with this fix in place the following type of errors were resolved:
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)