-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DLCPosVideo
: Use provided epoch, multithread matplotlib
#1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CBroz1
changed the title
Oct 18, 2024
DLCPosVideo
: Use provided epochDLCPosVideo
: Use provided epoch, multithread matplotlib
Draft pending resolution of bug report from user |
samuelbray32
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #1160 by allowing the
make_video
process to continue without aPosIntervalMap
entry.This PR is also a partial address of #1157 by reverting to
matplotlib
as the default video processor, and saves the output as temp files. OpenCV as a tool for reading frames was very memory hungry (300gb for 10k frames) during testing of batch processing, and was probably memory leaking somewhere. Switching to a two step process that saves each frame to disk, RAM usage hovered ~7gb over baseline with the current batch size. More work could be done to dial in these defaults to optimize video creation time based on available resourcesChecklist:
CITATION.cff
alter
snippet for release notes.CHANGELOG.md
with PR number and description.