Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLCPosVideo: Use provided epoch, multithread matplotlib #1168

Merged
merged 16 commits into from
Oct 29, 2024

Conversation

CBroz1
Copy link
Member

@CBroz1 CBroz1 commented Oct 16, 2024

Description

This PR addresses #1160 by allowing the make_video process to continue without a PosIntervalMap entry.

This PR is also a partial address of #1157 by reverting to matplotlib as the default video processor, and saves the output as temp files. OpenCV as a tool for reading frames was very memory hungry (300gb for 10k frames) during testing of batch processing, and was probably memory leaking somewhere. Switching to a two step process that saves each frame to disk, RAM usage hovered ~7gb over baseline with the current batch size. More work could be done to dial in these defaults to optimize video creation time based on available resources

Checklist:

  • No. This PR should be accompanied by a release: (yes/no/unsure)
  • N/a. If release, I have updated the CITATION.cff
  • No. This PR makes edits to table definitions: (yes/no)
  • N/a. If table edits, I have included an alter snippet for release notes.
  • N/a. If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • N/a. I have added/edited docs/notebooks to reflect the changes

@CBroz1 CBroz1 linked an issue Oct 16, 2024 that may be closed by this pull request
@CBroz1 CBroz1 changed the title DLCPosVideo: Use provided epoch DLCPosVideo: Use provided epoch, multithread matplotlib Oct 18, 2024
@CBroz1 CBroz1 marked this pull request as ready for review October 21, 2024 22:07
@CBroz1
Copy link
Member Author

CBroz1 commented Oct 23, 2024

Draft pending resolution of bug report from user

@CBroz1 CBroz1 marked this pull request as draft October 23, 2024 14:07
@CBroz1 CBroz1 marked this pull request as ready for review October 28, 2024 20:28
@edeno edeno requested a review from samuelbray32 October 28, 2024 20:32
@edeno edeno merged commit 6b4ff10 into LorenFrankLab:master Oct 29, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DLCPosVideo fails for non-existent interval
3 participants