Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup IntervalList orphans in weekly job only #1195

Merged
merged 6 commits into from
Dec 7, 2024
Merged

Conversation

samuelbray32
Copy link
Collaborator

@samuelbray32 samuelbray32 commented Nov 26, 2024

Description

Fixes #1194 (solution 2)

  • remove IntervalList cleanup from Mixin.delete()
  • Add IntervalList.cleanup() to documentation for nightly cron job

Checklist:

  • N This PR should be accompanied by a release: (yes/no/unsure)
  • NA If release, I have updated the CITATION.cff
  • N This PR makes edits to table definitions: (yes/no)
  • NA If table edits, I have included an alter snippet for release notes.
  • NA If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • NA I have added/edited docs/notebooks to reflect the changes

@samuelbray32 samuelbray32 requested a review from CBroz1 November 26, 2024 16:56
@samuelbray32 samuelbray32 marked this pull request as ready for review November 26, 2024 17:34
Copy link
Member

@CBroz1 CBroz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small note, but this looks good. Have you already edited the corresponding chron job script? I would want to make sure that's updated in tandem with this merge

docs/src/ForDevelopers/Management.md Outdated Show resolved Hide resolved
Co-authored-by: Chris Broz <Chris.Broz@ucsf.edu>
@edeno
Copy link
Collaborator

edeno commented Nov 27, 2024

Based on lab meeting discussion, should we move this to a weekly job?

@CBroz1
Copy link
Member

CBroz1 commented Nov 27, 2024

Based on lab meeting discussion, should we move this to a weekly job?

I think so. We could rename all nightly_cleanup to just cleanup, and set up a separate cron job for IntervalList.cleanup()

@edeno edeno changed the title Cleanup IntervalList orphans in nightly job only Cleanup IntervalList orphans in weekly job only Dec 2, 2024
@edeno
Copy link
Collaborator

edeno commented Dec 6, 2024

Going to merge today so we can make a release. @samuelbray32 is working on the cron job update. @samuelbray32 if you could fix the changelog sometime today that would be great.

Also copilot now generates useful pull request summaries which seem useful (below).

This pull request includes several changes to improve the cleanup process for orphaned entries in the IntervalList table and related documentation updates. The most important changes include renaming the nightly_cleanup method to cleanup, updating the documentation to reflect these changes, and adding the cleanup call to the main cleanup routine.

Cleanup process improvements:

Documentation updates:

  • CHANGELOG.md: Added an entry for the new cleanup process of IntervalList orphan entries to the nightly cleanup section.

Code simplification:

@samuelbray32
Copy link
Collaborator Author

updated the changelog in the commit merging master

@edeno edeno merged commit 11f7cfc into master Dec 7, 2024
17 checks passed
@edeno edeno deleted the nightly_orphan_cleanup branch December 7, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArtifactDetection creates orphan IntervalLists
3 participants