Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor decoding fixes #819

Merged
merged 339 commits into from
Feb 9, 2024
Merged

Minor decoding fixes #819

merged 339 commits into from
Feb 9, 2024

Conversation

edeno
Copy link
Collaborator

@edeno edeno commented Feb 5, 2024 •
edited
Loading

Description

Checklist:

  • This PR should be accompanied by a release: (yes/no/unsure)
  • (If release) I have updated the CITATION.cff
  • I have updated the CHANGELOG.md
  • I have added/edited docs/notebooks to reflect the changes

edeno and others added 30 commits January 3, 2024 14:14
@edeno
Use methods in populate
9e527ce
@edeno
Avoid fetching interval range if not needed
18d7af2
@edeno
Generalize finding class from modules
53fb7ef
@edeno
Use args/kwargs
2d5fa9c
@edeno
Simplify tuple unpacking
33fbf61
@edeno
Make decoding kwargs nullable
c8b4efb
@samuelbray32
Add function for get_recording and get_sorting to the spikesorting me…
1b06dac 
…rge table
@samuelbray32
make decoding waveform features agnostic to spikesorting source
28d44f7
@samuelbray32
Merge branch 'decoding-pipeline' of https://github.com/LorenFrankLab/…
7eed4af 
…spyglass into decoding-pipeline
@edeno
Fix spelling
c267cba
@edeno
Use fetch1_dataframe for position
a891747
@edeno
Use self instead of class
74c927d
@edeno @samuelbray32
Update src/spyglass/decoding/v1/sorted_spikes.py
bd4211e 
Co-authored-by: Samuel Bray <sam.bray@ucsf.edu>
@edeno
Be more careful about populating select keys
fa3c13d
@edeno
Make more readable/remove unused imports
3807db6
@edeno
Save classifier
3995e24
@edeno
Clean up saved model paths
d14f40f
@samuelbray32
add function load_linear_position_info
560a22a
@edeno @samuelbray32
Update src/spyglass/decoding/v1/sorted_spikes.py
3ead87e 
Co-authored-by: Samuel Bray <sam.bray@ucsf.edu>
@edeno
Update 41_Extracting_Clusterless_Waveform_Features.py
08c4c20
@edeno
Update docstring
158f4bc
@edeno
Merge branch 'master' into decoding-pipeline
e4ae6d9
@edeno @CBroz1
Apply suggestions from code review
4ec0f50 
Co-authored-by: Chris Brozdowski <Chris.Broz@ucsf.edu>
@edeno @CBroz1
Update src/spyglass/decoding/v1/clusterless.py
c01baad 
Co-authored-by: Chris Brozdowski <Chris.Broz@ucsf.edu>
@edeno @CBroz1
Update src/spyglass/decoding/v1/clusterless.py
17dad85 
Co-authored-by: Chris Brozdowski <Chris.Broz@ucsf.edu>
@edeno
Fix linting
34600d2
@edeno
Fix syntax
6d25232
@edeno
Rename variable to avoid confusion
7358ced
@edeno
Merge branch 'master' into decoding-pipeline
9aaa454
@edeno
Merge branch 'master' into decoding-pipeline
135d4e7
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@edeno
Copy link
Collaborator Author

edeno commented Feb 7, 2024 •
edited
Loading

To-Do:

  • Importing trials into table from NWB
  • Remove paper_plotting.py
  • Add spike raster to MUA figurl?

@edeno edeno marked this pull request as ready for review February 8, 2024 15:38
@edeno edeno requested a review from CBroz1 February 8, 2024 15:38
CBroz1
CBroz1 approved these changes Feb 8, 2024
View reviewed changes
src/spyglass/mua/v1/mua.py Outdated Show resolved Hide resolved
src/spyglass/mua/v1/mua.py Show resolved Hide resolved
src/spyglass/mua/v1/mua.py Outdated Show resolved Hide resolved
src/spyglass/mua/v1/mua.py Outdated Show resolved Hide resolved
src/spyglass/mua/v1/mua.py Outdated Show resolved Hide resolved
src/spyglass/ripple/v1/ripple.py Outdated Show resolved Hide resolved
notebooks/py_scripts/43_Decoding_SortedSpikes.py Outdated Show resolved Hide resolved
src/spyglass/ripple/v1/ripple.py Show resolved Hide resolved
src/spyglass/spikesorting/analysis/v1/group.py Show resolved Hide resolved
notebooks/py_scripts/51_MUA_Detection.py Outdated Show resolved Hide resolved
@edeno edeno merged commit ffe88c3 into master Feb 9, 2024
9 checks passed
@edeno edeno deleted the decoding-pipeline branch February 9, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBroz1 CBroz1 CBroz1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Figurl to visualize ripple detection as a way to diagnose problems
4 participants
@edeno @CBroz1 @samuelbray32 @khl02007