Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only apply include labels filter if include_labels not empty #827

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Only apply include labels filter if include_labels not empty #827

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6569210
dont skip unit if include_labels list is empty
samuelbray32 Feb 12, 2024
a4fcffa
update check for np array size
samuelbray32 Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/spyglass/spikesorting/analysis/v1/group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,10 @@ def filter_units(
for ind, unit_labels in enumerate(labels):
if isinstance(unit_labels, str):
unit_labels = [unit_labels]
if np.all(~np.isin(unit_labels, include_labels)) or np.any(
np.isin(unit_labels, exclude_labels)
):
if (
include_labels.size > 0
and np.all(~np.isin(unit_labels, include_labels))
) or np.any(np.isin(unit_labels, exclude_labels)):
# if the unit does not have any of the include labels
# or has any of the exclude labels, skip
continue
Expand Down
Loading