Merge tonsky#229

229: Update rubocop requirement from = 0.66.0 to = 0.67.1 r=bronzdoc a=dependabot[bot]

Updates the requirements on [rubocop](https://github.com/rubocop-hq/rubocop) to permit the latest version.
<details>
<summary>Release notes</summary>

*Sourced from [rubocop's releases](https://github.com/rubocop-hq/rubocop/releases).*

> ## RuboCop 0.67.1
> ### Changes
> 
> * [#6881](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6881): Set default `PreferredName` to `e` for `Naming/RescuedExceptionsVariableName`. ([@&#8203;koic][])
> 
> [@&#8203;koic]: https://github.com/koic
</details>
<details>
<summary>Changelog</summary>

*Sourced from [rubocop's changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md).*

> ## 0.67.1 (2019-04-04)
> 
> ### Changes
> 
> * [#6881](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6881): Set default `PreferredName` to `e` for `Naming/RescuedExceptionsVariableName`. ([@&#8203;koic][])
> 
> ## 0.67.0 (2019-04-04)
> 
> ### New features
> 
> * [#5184](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/5184): Add new multiline element line break cops. ([@&#8203;maxh][])
> * Add new cop `Rails/ActiveRecordOverride` that checks for overriding Active Record methods instead of using callbacks. ([@&#8203;elebow][])
> * Add new cop `Rails/RedundantAllowNil` that checks for cases when `allow_blank` makes `allow_nil` unnecessary in model validations. ([@&#8203;elebow][])
> * Add new `Naming/RescuedExceptionsVariableName` cop. ([@&#8203;AdrienSldy][])
> 
> ### Bug fixes
> 
> * [#6761](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6761): Make `Naming/UncommunicativeMethodParamName` account for param names prefixed with underscores. ([@&#8203;thomthom][])
> * [#6855](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6855): Fix an exception in `Rails/RedundantReceiverInWithOptions` when the body is empty. ([@&#8203;ericsullivan][])
> * [#6856](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6856): Fix auto-correction for `Style/BlockComments` when the file is missing a trailing blank line. ([@&#8203;ericsullivan][])
> * [#6858](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6858): Fix an incorrect auto-correct for `Lint/ToJSON` when there are no `to_json` arguments. ([@&#8203;koic][])
> * [#6865](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6865): Fix deactivated `StyleGuideBaseURL` for `Layout/ClassStructure`. ([@&#8203;aeroastro][])
> * [#6868](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6868): Fix `Rails/LinkToBlank` auto-correct bug when using symbol for target. ([@&#8203;r7kamura][])
> * [#6869](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6869): Fix false positive for `Rails/LinkToBlank` when rel is a symbol value. ([@&#8203;r7kamura][])
> * Add `IncludedMacros` param to default rubocop config for `Style/MethodCallWithArgsParentheses`. ([@&#8203;maxh][])
> * [#6785](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6785): Do not register an offense for `Rails/Present` or `Rails/Blank` in an `unless else` context when `Style/UnlessElse` is enabled. ([@&#8203;rrosenblum][])
> 
> ### Changes
> 
> * [#6854](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6854): Mark Rails/LexicallyScopedActionFilter as unsafe and document risks. ([@&#8203;urbanautomaton][])
> * [#5977](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/5977): Warn for Performance Cops. ([@&#8203;koic][])
> * [#6637](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6637): Move `LstripRstrip` from `Performance` to `Style` department and rename it to `Strip`. ([[@&#8203;anuja](https://github.com/anuja)-joshi][])
> * [#6875](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6875): Mention block form of `Struct.new` in ` Style/StructInheritance`. ([@&#8203;XrXr][])
> * [#6871](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6871): Move `Performance/RedundantSortBy`, `Performance/UnneededSort` and `Performance/Sample` to the Style department. ([@&#8203;bbatsov][])
> 
> ## 0.66.0 (2019-03-18)
> 
> ### New features
> 
> * [#6393](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6393): Add `AllowBracesOnProceduralOneLiners` option to fine-tune `Style/BlockDelimiter`'s semantic mode. ([@&#8203;davearonson][])
> * [#6383](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6383): Add `AllowBeforeTrailingComments` option on `Layout/ExtraSpacing` cop. ([@&#8203;davearonson][])
> * New cop `Lint/SafeNavigationWithEmpty` checks for `foo&.empty?` in conditionals. ([@&#8203;rspeicher][])
> * Add new `Style/ConstantVisibility` cop for enforcing visibility declarations of class and module constants. ([@&#8203;drenmi][])
> * [#6378](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6378): Add `Lint/ToJSON` cop to enforce an argument when overriding `#to_json`. ([@&#8203;allcentury][])
> * [#6346](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6346): Add auto-correction to `Rails/TimeZone`. ([@&#8203;dcluna][])
> * [#6840](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6840): Node patterns now allow unlimited elements after `...`. ([@&#8203;marcandre][])
> 
> ### Bug fixes
> 
> * [#4321](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/4321): Fix false offense for `Style/RedundantSelf` when the method is also defined on `Kernel`. ([@&#8203;mikegee][])
></tr></table> ... (truncated)
</details>
<details>
<summary>Commits</summary>

- [`01918a1`](rubocop/rubocop@01918a1) Cut 0.67.1
- [`d0677d7`](rubocop/rubocop@d0677d7) Set default `PreferredName` to `e` for `Naming/RescuedExceptionsVariableName`
- [`1d0e480`](rubocop/rubocop@1d0e480) Cut 0.67
- [`2513212`](rubocop/rubocop@2513212) Fix the manual
- [`f0959e8`](rubocop/rubocop@f0959e8) Add new Naming/RescuedExceptionsVariableName cop
- [`b05bb15`](rubocop/rubocop@b05bb15) [Fix [#6785](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6785)] Make Rails/Blank and Rails/Present aware of Style/UnlessElse
- [`93b1fc1`](rubocop/rubocop@93b1fc1) Update a bit of cop metadata
- [`ad5c5f9`](rubocop/rubocop@ad5c5f9) [Fix [#5184](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/5184)] Add new multiline element line break cops ([#6824](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6824))
- [`2a4dfca`](rubocop/rubocop@2a4dfca) Add `STDERR.puts` check to Style/StderrPuts cop
- [`32ed7d1`](rubocop/rubocop@32ed7d1) [Fix [#6871](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6871)] Move several performance cops to the style department
- Additional commits viewable in [compare view](rubocop/rubocop@v0.66.0...v0.67.1)
</details>
<br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>

Co-authored-by: dependabot[bot] <support@dependabot.com>
Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>

gemstash.gemspec

@@ -59,5 +59,5 @@ you push your own private gems as well."
   spec.add_development_dependency "rack-test", "~> 1.1"
   spec.add_development_dependency "rake", "~> 12.3"
   spec.add_development_dependency "rspec", "~> 3.3"
-  spec.add_development_dependency "rubocop", "= 0.66.0"
+  spec.add_development_dependency "rubocop", "= 0.67.1"
 end

spec/support/simple_server.rb

@@ -155,7 +155,7 @@ def do_GET(request, response) # rubocop:disable Naming/MethodName
       if @simple_server.routes.include?(request.path)
         @simple_server.routes[request.path].call request, response
       else
-        STDERR.puts "[SimpleServer] no route found: #{request.path}"
+        warn "[SimpleServer] no route found: #{request.path}"
         raise WEBrick::HTTPStatus::NotFound
       end
     end