Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OG bug: If Lara is standing in 2 clicks of water while holding a flare, bubbles appear above the water #1590

Closed
aredfan opened this issue Jul 6, 2024 · 1 comment · Fixed by #2137
Closed

OG bug: If Lara is standing in 2 clicks of water while holding a flare, bubbles appear above the water #1590

aredfan opened this issue Jul 6, 2024 · 1 comment · Fixed by #2137
Assignees
@lahm86
Labels
OG bug A bug in original game TR2

Comments

@aredfan
Copy link
Collaborator

aredfan commented Jul 6, 2024 •
edited
Loading

Screenshots show Bartoli's Hideout (VENICE.TR2), room 139.

1

2
@aredfan aredfan added the OG bug A bug in original game label Jul 6, 2024
@rr- rr- added the TR2 label Oct 3, 2024
@rr- rr- transferred this issue from LostArtefacts/TR2X Oct 3, 2024
@rr- rr- moved this to Backlog in TRX Dev tracker Oct 10, 2024
@lahm86 lahm86 self-assigned this Dec 27, 2024
@lahm86 lahm86 moved this from Backlog to In progress in TRX Dev tracker Dec 27, 2024
@lahm86
Copy link
Collaborator

lahm86 commented Dec 27, 2024

Also related to this, the sound effects for the flare igniting and burning don't play when Lara's technically in a water room but her hand isn't.

lahm86 added a commit to lahm86/TRX that referenced this issue Dec 28, 2024
@lahm86
tr2/flares: fix flare effects in shallow water
57b4f24 
This ensures we test water height at a flare's exact positions rather
than using Lara's general room number, so to determine if bubbles
should spawn and how to play sound effects.

Resolves LostArtefacts#1590.
@lahm86 lahm86 mentioned this issue Dec 28, 2024
Merged
2 tasks
lahm86 added a commit to lahm86/TRX that referenced this issue Dec 28, 2024
@lahm86
tr2/flares: fix flare effects in shallow water
a056e29 
This ensures we test water height at a flare's exact positions rather
than using Lara's general room number, so to determine if bubbles
should spawn and how to play sound effects.

Resolves LostArtefacts#1590.
@lahm86 lahm86 closed this as completed in c6bb509 Dec 28, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in TRX Dev tracker Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lahm86 lahm86

Labels
OG bug A bug in original game TR2
Projects
TRX Dev tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tr2/flares: fix flare effects in shallow water lahm86/TRX
3 participants
@rr- @lahm86 @aredfan