Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gameflow forced variables #1857

Closed
lahm86 opened this issue Nov 10, 2024 · 0 comments · Fixed by #1858
Closed

Remove gameflow forced variables #1857

lahm86 opened this issue Nov 10, 2024 · 0 comments · Fixed by #1858
Assignees
Labels
Enhancement Improvement of an existing feature TR1

Comments

@lahm86
Copy link
Collaborator

lahm86 commented Nov 10, 2024

Following #1854, force_game_modes and force_save_crystals are no longer required in the gameflow as these can be enforced in the config JSON instead by builders.

@lahm86 lahm86 added Enhancement Improvement of an existing feature TR1 labels Nov 10, 2024
@lahm86 lahm86 self-assigned this Nov 10, 2024
@lahm86 lahm86 moved this to In progress in TRX Dev tracker Nov 10, 2024
lahm86 added a commit to lahm86/TRX that referenced this issue Nov 10, 2024
This removes the dedicated enforced game modes and save crystals
settings from the gameflow, as these can now be controlled by builders
in the main config file.

Resolves LostArtefacts#1857.
lahm86 added a commit to lahm86/TRX that referenced this issue Nov 10, 2024
This removes the dedicated enforced game modes and save crystals
settings from the gameflow, as these can now be controlled by builders
in the main config file.

Resolves LostArtefacts#1857.
lahm86 added a commit to lahm86/TRX that referenced this issue Nov 10, 2024
This removes the dedicated enforced game modes and save crystals
settings from the gameflow, as these can now be controlled by builders
in the main config file.

Resolves LostArtefacts#1857.
@lahm86 lahm86 moved this from In progress to In review in TRX Dev tracker Nov 10, 2024
lahm86 added a commit to lahm86/TRX that referenced this issue Nov 11, 2024
This refactors the enforced config control from LostArtefacts#1854 into the gameflow
and removes the legacy settings for enforcing game modes and save
crystals.

Resolves LostArtefacts#1857.
lahm86 added a commit to lahm86/TRX that referenced this issue Nov 11, 2024
This refactors the enforced config control from LostArtefacts#1854 into the gameflow
and removes the legacy settings for enforcing game modes and save
crystals.

Resolves LostArtefacts#1857.
lahm86 added a commit to lahm86/TRX that referenced this issue Nov 11, 2024
This refactors the enforced config control from LostArtefacts#1854 into the gameflow
and removes the legacy settings for enforcing game modes and save
crystals.

Resolves LostArtefacts#1857.
lahm86 added a commit to lahm86/TRX that referenced this issue Nov 11, 2024
This refactors the enforced config control from LostArtefacts#1854 into the gameflow
and removes the legacy settings for enforcing game modes and save
crystals.

Resolves LostArtefacts#1857.
@lahm86 lahm86 closed this as completed in f0f7edc Nov 11, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in TRX Dev tracker Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement of an existing feature TR1
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant