Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve translation support for text under passport #1971

Closed
antonio3687 opened this issue Nov 28, 2024 · 1 comment · Fixed by #1982
Closed

Improve translation support for text under passport #1971

antonio3687 opened this issue Nov 28, 2024 · 1 comment · Fixed by #1982
Assignees
@lahm86
Labels
TR1 TRX bug A bug with TRX

Comments

@antonio3687
Copy link

20241128_220922_El_coliseo
20241128_220937_El_coliseo
20241128_221138_El_coliseo
Good evening, did you fix the textures in the coliseum level or am I confused? The texts are joined with the arrows as seen in the attached images, the texts of the main menu also happens the same. Greetings and thank you very much.
@aredfan
Copy link
Collaborator

aredfan commented Nov 28, 2024 •
edited
Loading

Hi @antonio3687, you're correct that the Colosseum roof textures have been changed. The new roof texture is taken from a beta version of Tomb Raider 1, and is added to TR1X when using the Fix texture issues option in the config.

The grey arrows issue is probably because it has a fixed position and doesn't shift dynamically if the text string gets longer.

@aredfan aredfan added TRX bug A bug with TRX TR1 labels Nov 28, 2024
@rr- rr- changed the title Colosseum textures and texts Improve translation support for text under passport Nov 28, 2024
@rr- rr- moved this to Ready in TRX Dev tracker Nov 28, 2024
lahm86 added a commit to lahm86/TRX that referenced this issue Dec 2, 2024
@lahm86
tr1/option/option_passport: move passport arrows based on text size
539eec9 
This shifts the arrows at the bottom of the passport with respect to
the size of the text, so to avoid overlapping.

Resolves LostArtefacts#1971.
@lahm86 lahm86 self-assigned this Dec 2, 2024
@lahm86 lahm86 moved this from Ready to In progress in TRX Dev tracker Dec 2, 2024
@lahm86 lahm86 mentioned this issue Dec 2, 2024
Merged
2 tasks
@lahm86 lahm86 closed this as completed in 8fbcf5e Dec 3, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in TRX Dev tracker Dec 3, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in TRX Dev tracker Dec 3, 2024
@lahm86 lahm86 mentioned this issue Dec 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lahm86 lahm86

Labels
TR1 TRX bug A bug with TRX
Projects
TRX Dev tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tr1/option/option_passport: move passport arrows based on text size lahm86/TRX
3 participants
@lahm86 @aredfan @antonio3687