Fix wibble effect seams in level geometry #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes TR1X crashes when trying to launch with an invalid shader.
Resolves TR1X part of #1493.
rr-
requested review from
lahm86,
walkawayy and
aredfan
and removed request for
a team
lahm86
approved these changes
Oct 4, 2024
aredfan
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
I've mostly checked the water room in the 3 levels with skyboxes because that's where the seams are most evident. The seams issue is fixed in nearly all cases.
There's a few stray seams remaining in Obelisk of Khamoon, room 42. These seams are also present in OG too so nothing new there. No worries if there's no fix to be found for this case.
Regardless, this is a massive improvement compared to how the wibble effect worked in OG, thank you. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
#1493
Uses double rendering of underwater rooms with the wibble effect disabled (and Z-buffer writes off, to avoid depth races) to provide sensible pixels in the seams.
This has a chance of affecting performance in pools.