Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tr2/output: fix crash with z-buffer disabled #1791

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Conversation

rr-
Copy link
Collaborator

@rr- rr- commented Nov 1, 2024

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

Resolves #1761.

@rr- rr- added TRX bug A bug with TRX TR2 labels Nov 1, 2024
@rr- rr- self-assigned this Nov 1, 2024
@rr- rr- requested review from a team as code owners November 1, 2024 23:19
@rr- rr- requested review from lahm86, walkawayy and aredfan and removed request for a team November 1, 2024 23:19
@aredfan
Copy link
Collaborator

aredfan commented Nov 2, 2024

The game crashing is now fixed, thank you.

I came across a secondary issue while testing with z-buffer disabled - the boat's static can disappear and the dev console isn't visible when opened in this position. When I use /kill all, the issues end up geting fixed so I'm guessing it's a game limitation.

Save: savegame.zip

Screenshot

@rr-
Copy link
Collaborator Author

rr- commented Nov 2, 2024

Thanks - that's indeed an OG limitation. Let's have it logged as a separate ticket.

@rr- rr- merged commit 6651aac into develop Nov 2, 2024
7 checks passed
@rr- rr- deleted the issue-1761-z-buffer-crash branch November 2, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TR2 TRX bug A bug with TRX
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

TRX bug: potential crash when z-buffer is disabled
2 participants