-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gfx refactor #1997
Merged
Merged
Gfx refactor #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren't really using them, anyway.
rr-
requested review from
lahm86,
walkawayy and
aredfan
and removed request for
a team
December 9, 2024 22:29
Download the built assets for this pull request: |
walkawayy
approved these changes
Dec 9, 2024
aredfan
approved these changes
Dec 9, 2024
lahm86
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Extracted from #1983. Reorganizes and extends the gfx module in a couple of ways:
None of these changes, aside from fixed uninitialized strides, alter the game or introduce new settings – these are only internal API changes.
Since the GFX module is not used at all by TR2 in
develop
, and TR1 doesn't use any of the new features, I suppose it's sufficient to only do light sanity testing of TR1.