Master #7
Merged
Master #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make InstrumentTrackWindow as large as the InstrumentView requires
Previously, they had been resized by the fixed size parent tab widget. We need to do this manually now.
- Fix the instrument window tabs minimum width and height formulae - Also set minimum height and width for instrument tab
* [Equalizer] Bright analyzer colors, opacity incr Brightened spectrum analyzer colors and increased opacity a tad to make more visible * Fixed RGB Value * Update EqControlsDialog.cpp * Fixed color change * Changed colors again * Fixed colors, now brighter and bluer * Ok, its actually bright now lol
Fixes crash on loading presets with controllers.
Other changes: * Update TCO position more exact when a drag leaves a TCO and enters `TrackContentWidget` (required to detect that the cursor has really moved when leaving a TCO with length < 1 to the right) * Use exact length when samples are loaded, don't round it up * Reset size when reloading same file
Fixes crash on cloning patterns on Qt >= 5.12.
In the instrument plugin tab, there was an orange stripe for TripleOscillator. This was because internally, TabWidget moves up the widget by 1 (TabWidget.cpp, line 89). The size of the whole window is: ``` widget->height() + m_tabbarHeight - 1 ``` So this code adds an offset of "-1" to the necessary computations.
…the tree is reloaded.
* Added check for chord to notes recorded from keyboard
* document `dcast` * make `dcast` not only cast exact, but also upwards * add `dcast` test * rename `dcast` -> `dynamicCast`
Check whether returned pointers from the cast are equal to the original pointers, rather than just checking wether they are not `nullptr`.
Make Model class visitable
Uses 18.04's debian-archive-keyring to fix the missing keyrings.
As of probonopd/linuxdeployqt#370, the AppRun of linuxdeployqt unsets LD_LIBRARY_PATH. This behavior isn't suitable for our cases, so we use the extracted binary directly as a workaround.
Fixes a regression in 32df2d7, the clipping area was restored in a wrong place. Also, a wrong value was used while restoring.
# Conflicts: # CMakeLists.txt # cmake/linux/package_linux.sh.in # src/3rdparty/CMakeLists.txt # src/core/Track.cpp # src/gui/editors/PianoRoll.cpp # src/tracks/SampleTrack.cpp
playing/recording pianoRoll's chord notes (#4963)
Add `override` keyword
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.