Temporarily disable specs that create TaxRates

solidusio#1851 will change the
type of relation to a many to many so specs will temporarily need to
be skipped until changes are made to the specs.

core/spec/lib/spree/core/price_migrator_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Spree::PriceMigrator do
+describe Spree::PriceMigrator, skip: true do
   let(:order) { create :order, ship_address: shipping_address, state: "delivery" }
   let(:book_product) do
     create :product,
@@ -55,7 +55,7 @@
         name: "German reduced VAT",
         included_in_price: true,
         amount: 0.07,
-        tax_category: books_category,
+        tax_categories: [books_category],
         zone: eu_zone
       )
     end
@@ -65,7 +65,7 @@
         name: "German VAT",
         included_in_price: true,
         amount: 0.19,
-        tax_category: normal_category,
+        tax_categories: [normal_category],
         zone: eu_zone
       )
     end
@@ -75,7 +75,7 @@
         name: "German VAT",
         included_in_price: true,
         amount: 0.19,
-        tax_category: digital_category,
+        tax_categories: [digital_category],
         zone: germany_zone
       )
     end
@@ -85,7 +85,7 @@
         name: "Romanian VAT",
         included_in_price: true,
         amount: 0.24,
-        tax_category: digital_category,
+        tax_categories: [digital_category],
         zone: romania_zone
       )
     end

core/spec/lib/spree/core/testing_support/factories/order_factory_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 require 'spree/testing_support/factories/order_factory'
 
-RSpec.describe 'order factory' do
+RSpec.describe 'order factory', skip: true do
   let(:factory_class) { Spree::Order }
 
   describe 'plain order' do
@@ -79,7 +79,7 @@
     context 'when shipments should be taxed' do
       let!(:ship_address) { create(:address) }
       let!(:tax_zone) { create(:global_zone) } # will include the above address
-      let!(:tax_rate) { create(:tax_rate, amount: 0.10, zone: tax_zone, tax_category: tax_category) }
+      let!(:tax_rate) { create(:tax_rate, amount: 0.10, zone: tax_zone, tax_categories: [tax_category]) }
 
       let(:tax_category) { create(:tax_category) }
       let(:shipping_method) { create(:shipping_method, tax_category: tax_category, zones: [tax_zone]) }

core/spec/models/spree/calculator/default_tax_spec.rb

@@ -1,12 +1,12 @@
 require 'spec_helper'
 require 'shared_examples/calculator_shared_examples'
 
-describe Spree::Calculator::DefaultTax, type: :model do
+describe Spree::Calculator::DefaultTax, type: :model, skip: true do
   let(:address) { create(:address) }
   let!(:zone) { create(:zone, name: "Country Zone", default_tax: default_tax, countries: [tax_rate_country]) }
   let(:tax_rate_country) { address.country }
   let(:tax_category) { create(:tax_category) }
-  let!(:rate) { create(:tax_rate, tax_category: tax_category, amount: 0.05, included_in_price: included_in_price, zone: zone) }
+  let!(:rate) { create(:tax_rate, tax_categories: [tax_category], amount: 0.05, included_in_price: included_in_price, zone: zone) }
   let(:included_in_price) { false }
   let(:default_tax) { false }
   subject(:calculator) { Spree::Calculator::DefaultTax.new(calculable: rate ) }

core/spec/models/spree/order/checkout_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 require 'spree/testing_support/order_walkthrough'
 
-describe Spree::Order, type: :model do
+describe Spree::Order, type: :model, skip: true do
   let!(:store) { create(:store) }
   let(:order) { Spree::Order.new(store: store) }
 
@@ -184,7 +184,7 @@ def assert_state_changed(order, from, to)
 
       it "recalculates tax and updates totals" do
         zone = create(:zone, countries: [order.tax_address.country])
-        create(:tax_rate, tax_category: line_item.tax_category, amount: 0.05, zone: zone)
+        create(:tax_rate, tax_categories: [line_item.tax_category], amount: 0.05, zone: zone)
         order.next!
         expect(order).to have_attributes(
           adjustment_total: 0.5,

core/spec/models/spree/order_capturing_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Spree::OrderCapturing do
+describe Spree::OrderCapturing, skip: true do
   describe '#capture_payments' do
     subject { Spree::OrderCapturing.new(order, payment_methods).capture_payments }
 
@@ -38,7 +38,7 @@
 
       let!(:product) { create(:product, price: 10.00) }
       let!(:variant) do
-        create(:variant, price: 10, product: product, track_inventory: false, tax_category: tax_rate.tax_category)
+        create(:variant, price: 10, product: product, track_inventory: false, tax_category: tax_rate.tax_categories.first)
       end
       let!(:shipping_method) { create(:free_shipping_method) }
       let(:tax_rate) { create(:tax_rate, amount: 0.1, zone: create(:global_zone, name: "Some Tax Zone")) }

core/spec/models/spree/order_contents_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Spree::OrderContents, type: :model do
+describe Spree::OrderContents, type: :model, skip: true do
   let!(:store) { create :store }
   let(:order) { create(:order) }
   let(:variant) { create(:variant) }
@@ -123,7 +123,7 @@
     describe 'tax calculations' do
       let!(:zone) { create(:global_zone) }
       let!(:tax_rate) do
-        create(:tax_rate, zone: zone, tax_category: variant.tax_category)
+        create(:tax_rate, zone: zone, tax_categories: [variant.tax_category])
       end
 
       context 'when the order has a taxable address' do

core/spec/models/spree/order_updater_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 module Spree
-  describe OrderUpdater, type: :model do
+  describe OrderUpdater, type: :model, skip: true do
     let!(:store) { create :store }
     let(:order) { Spree::Order.create }
     let(:updater) { Spree::OrderUpdater.new(order) }
@@ -273,7 +273,7 @@ def create_adjustment(label, amount)
       describe 'tax recalculation' do
         let!(:ship_address) { create(:address) }
         let!(:tax_zone) { create(:global_zone) } # will include the above address
-        let!(:tax_rate) { create(:tax_rate, zone: tax_zone, tax_category: tax_category) }
+        let!(:tax_rate) { create(:tax_rate, zone: tax_zone, tax_categories: [tax_category]) }
 
         let(:order) do
           create(

core/spec/models/spree/price_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Spree::Price, type: :model do
+describe Spree::Price, type: :model, skip: true do
   describe 'searchable columns' do
     subject { described_class.whitelisted_ransackable_attributes }
     it 'allows searching by variant_id' do
@@ -133,7 +133,7 @@
   describe 'net_amount' do
     let(:country) { create(:country, iso: "DE") }
     let(:zone) { create(:zone, countries: [country]) }
-    let!(:tax_rate) { create(:tax_rate, included_in_price: true, zone: zone, tax_category: variant.tax_category) }
+    let!(:tax_rate) { create(:tax_rate, included_in_price: true, zone: zone, tax_categories: [variant.tax_category]) }
 
     let(:variant) { create(:product).master }
 

core/spec/models/spree/promotion_handler/coupon_spec.rb

@@ -2,7 +2,7 @@
 
 module Spree
   module PromotionHandler
-    describe Coupon, type: :model do
+    describe Coupon, type: :model, skip: true do
       let(:order) { double("Order", coupon_code: "10off").as_null_object }
 
       subject(:coupon) { Coupon.new(order) }
@@ -255,7 +255,7 @@ def expect_adjustment_creation(adjustable:, promotion:, promotion_code:nil)
           let(:order) { create(:order, store: store) }
           let(:tax_category) { create(:tax_category, name: "Taxable Foo") }
           let(:zone) { create(:zone, :with_country) }
-          let!(:tax_rate) { create(:tax_rate, amount: 0.1, tax_category: tax_category, zone: zone )}
+          let!(:tax_rate) { create(:tax_rate, amount: 0.1, tax_categories: [tax_category], zone: zone ) }
 
           before(:each) do
             expect(order).to receive(:tax_address).at_least(:once).and_return(Spree::Tax::TaxLocation.new(country: zone.countries.first))

core/spec/models/spree/shipment_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 require 'benchmark'
 
-describe Spree::Shipment, type: :model do
+describe Spree::Shipment, type: :model, skip: true do
   let(:order) { create(:order_ready_to_ship, line_items_count: 1) }
   let(:shipping_method) { create(:shipping_method, name: "UPS") }
   let(:stock_location) { create(:stock_location) }
@@ -130,7 +130,7 @@
 
     let!(:ship_address) { create(:address) }
     let!(:tax_zone) { create(:global_zone) } # will include the above address
-    let!(:tax_rate) { create(:tax_rate, amount: 0.1, zone: tax_zone, tax_category: tax_category) }
+    let!(:tax_rate) { create(:tax_rate, amount: 0.1, zone: tax_zone, tax_categories: [tax_category]) }
     let(:tax_category) { create(:tax_category) }
     let(:variant) { create(:variant, tax_category: tax_category) }
 
@@ -548,7 +548,7 @@
   context "changes shipping rate via general update" do
     let!(:ship_address) { create(:address) }
     let!(:tax_zone) { create(:global_zone) } # will include the above address
-    let!(:tax_rate) { create(:tax_rate, amount: 0.10, zone: tax_zone, tax_category: tax_category) }
+    let!(:tax_rate) { create(:tax_rate, amount: 0.10, zone: tax_zone, tax_categories: [tax_category]) }
     let(:tax_category) { create(:tax_category) }
 
     let(:order) do

core/spec/models/spree/shipping_rate_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Spree::ShippingRate, type: :model do
+describe Spree::ShippingRate, type: :model, skip: true do
   let(:address) { create(:address) }
   let(:foreign_address) { create :address, country_iso_code: "DE" }
   let(:order) { create :order, ship_address: address }
@@ -33,7 +33,7 @@
         included_in_price: true,
         name: "VAT",
         zone: default_zone,
-        tax_category: tax_category
+        tax_categories: [tax_category]
       end
 
       let(:order_address) { address }
@@ -64,7 +64,7 @@
         included_in_price: true,
         name: "VAT",
         zone: default_zone,
-        tax_category: tax_category
+        tax_categories: [tax_category]
       end
 
       let(:order_address) { foreign_address }
@@ -96,7 +96,7 @@
         included_in_price: false,
         name: "Sales Tax",
         zone: default_zone,
-        tax_category: tax_category
+        tax_categories: [tax_category]
       end
 
       let(:order_address) { address }
@@ -126,15 +126,15 @@
         included_in_price: false,
         name: "Sales Tax",
         zone: default_zone,
-        tax_category: tax_category
+        tax_categories: [tax_category]
       end
 
       let!(:other_tax_rate) do
         create :tax_rate,
         included_in_price: false,
         name: "Other Sales Tax",
         zone: default_zone,
-        tax_category: tax_category,
+        tax_categories: [tax_category],
         amount: 0.05
       end
 

core/spec/models/spree/stock/estimator_spec.rb

@@ -2,7 +2,7 @@
 
 module Spree
   module Stock
-    describe Estimator, type: :model do
+    describe Estimator, type: :model, skip: true do
       let(:shipping_rate) { 4.00 }
       let!(:shipping_method) { create(:shipping_method, cost: shipping_rate, currency: currency) }
       let(:package) do
@@ -145,7 +145,7 @@ module Stock
           let!(:tax_rate) { create(:tax_rate, zone: zone) }
 
           before do
-            shipping_method.update!(tax_category: tax_rate.tax_category)
+            shipping_method.update!(tax_category: tax_rate.tax_categories.first)
           end
 
           it "links the shipping rate and the tax rate" do

core/spec/models/spree/tax/item_adjuster_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-RSpec.describe Spree::Tax::ItemAdjuster do
+RSpec.describe Spree::Tax::ItemAdjuster, skip: true do
   subject(:adjuster) { described_class.new(item) }
   let(:order) { create(:order) }
   let(:item) { create(:line_item, order: order) }
@@ -65,15 +65,42 @@ def tax_adjustments
 
       context 'when there are matching rates for the zone' do
         context 'and all rates have the same tax category as the item' do
-          let(:item) { build_stubbed :line_item, order: order, tax_category: item_tax_category }
-          let(:item_tax_category) { build_stubbed(:tax_category) }
-          let(:rate_1) { create :tax_rate, tax_category: item_tax_category }
+          let(:item) { create :line_item, order: order, tax_category: item_tax_category }
+          let(:item_tax_category) { create(:tax_category) }
+          let(:rate_1) { create :tax_rate, tax_categories: [item_tax_category], amount: 0.1 }
           let(:rate_2) { create :tax_rate }
-          let(:rates_for_order_zone) { [rate_1, rate_2] }
+          let(:rate_3) { create :tax_rate, tax_categories: [item_tax_category, build(:tax_category)] }
+          let(:rates_for_order_zone) { [rate_1, rate_2, rate_3] }
 
           it 'creates an adjustment for every matching rate' do
             adjuster.adjust!
-            expect(tax_adjustments.length).to eq(1)
+            expect(tax_adjustments.length).to eq(2)
+          end
+
+          it 'creates adjustments only for matching rates' do
+            adjuster.adjust!
+            expect(tax_adjustments.map(&:source)).to match_array([rate_1, rate_3])
+          end
+
+          context 'when the adjustment exists' do
+            before do
+              adjuster.adjust!
+            end
+
+            context 'when the existing adjustment is finalized' do
+              before do
+                tax_adjustments.first.finalize!
+              end
+
+              it 'updates the adjustment' do
+                item.update_columns(price: item.price * 2)
+                adjuster.adjust!
+                tax_rate1_adjustment = tax_adjustments.detect do |adjustment|
+                  adjustment.source == rate_1
+                end
+                expect(tax_rate1_adjustment.amount).to eq(0.1 * item.price)
+              end
+            end
           end
         end
       end

core/spec/models/spree/tax/shipping_rate_taxer_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Spree::Tax::ShippingRateTaxer do
+describe Spree::Tax::ShippingRateTaxer, skip: true do
   let(:shipping_rate) { build_stubbed(:shipping_rate) }
 
   subject(:taxer) { described_class.new(shipping_rate) }
@@ -22,12 +22,19 @@
       let(:shipment) { create :shipment, order: order }
       let!(:shipping_method) { create :shipping_method, tax_category: tax_category, zones: [zone] }
       let(:zone) { create :zone, countries: [ship_address.country] }
-      let!(:tax_rate_one) { create :tax_rate, tax_category: tax_category, zone: zone, amount: 0.1 }
-      let!(:tax_rate_two) { create :tax_rate, tax_category: tax_category, zone: zone, amount: 0.2 }
+      let!(:tax_rate_one) { create :tax_rate, tax_categories: [tax_category], zone: zone, amount: 0.1 }
+      let!(:tax_rate_two) do
+        create(
+          :tax_rate,
+          tax_categories: [create(:tax_category), tax_category],
+          zone: zone,
+          amount: 0.2
+        )
+      end
       let!(:non_applicable_rate) { create :tax_rate, zone: zone }
       let(:shipping_rate) { create :shipping_rate, cost: 10, shipping_method: shipping_method }
 
-      it 'builds a shipping rate tax for every tax rate' do
+      it 'builds a shipping rate tax for every matching tax rate' do
         expect(subject.taxes.length).to eq(2)
         expect(subject.taxes.map(&:tax_rate)).to include(tax_rate_one)
         expect(subject.taxes.map(&:tax_rate)).to include(tax_rate_two)