This repository has been archived by the owner on Apr 26, 2022. It is now read-only.
Make last names optional on Spree::Address #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, we're integrating with Amazon Payments right now and Amazon doesn't require two names, which breaks this validation. And it's hard to remove an ActiveRecord validation at the app level.
| @@ -5,7 +5,7 @@ class Address < Spree::Base | |||
| belongs_to :country, class_name: "Spree::Country" | |||
| belongs_to :state, class_name: "Spree::State" | |||
|
|
|||
| validates :firstname, :lastname, :address1, :city, :country_id, presence: true | |||
There was a problem hiding this comment.
Is this not going to potentially be a breaking change for some people? Did you find why this was required in the first place or is it one of those "historic" things?
There was a problem hiding this comment.
Answered in the PR on Solidus: solidusio#1369
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(See Solidus PR 1369)
Amazon Payments doesn't require two names, which breaks this
validation. It's hard to remove an ActiveRecord validation at the
app level.