Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web|react): update build target from ES2020 to ES2015 #358

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

theashraf
Copy link
Member

Changes:

  • Build dotlottie-web and dotlottie-react for ES2015 instead of ES2020.
  • This resolves issues on platforms that don't support ES2020 by default, ensuring compatibility with ES6.
  • Added a babel example to illustrate cases where ES2020 features, such as optional chaining, are not supported.

Copy link

changeset-bot bot commented Sep 24, 2024

🦋 Changeset detected

Latest commit: 12fb609

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@lottiefiles/dotlottie-react Minor
@lottiefiles/dotlottie-web Minor
@lottiefiles/dotlottie-solid Patch
@lottiefiles/dotlottie-svelte Patch
@lottiefiles/dotlottie-vue Patch
@lottiefiles/dotlottie-wc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@theashraf theashraf changed the title feat(web,react): 🎸 build for ES2015 chore(web|react): update build target from ES2020 to ES2015 Sep 24, 2024
@@ -2,10 +2,6 @@
"name": "@lottiefiles/dotlottie-web-monorepo",
"license": "MIT",
"private": true,
"workspaces": [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer needed with pnpm v9

Copy link
Contributor

Coverage Report for @lottiefiles/dotlottie-web (packages/web)

Status Category Percentage Covered / Total
🟢 Lines 56.47% / 30% 580 / 1027
🟢 Statements 55.05% / 30% 604 / 1097
🟢 Functions 56.81% / 30% 150 / 264
🟢 Branches 59.1% / 30% 383 / 648
File CoverageNo changed files found.
Generated in workflow #1328

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
@lottiefiles/dotlottie-web 40.21 KB (+3.72% 🔺) 805 ms (+3.72% 🔺) 310 ms (+14.61% 🔺) 1.2 s
@lottiefiles/dotlottie-web WASM 393.11 KB (0%) 7.9 s (0%) 0 ms (+100% 🔺) 7.9 s
@lottiefiles/dotlottie-react 43.52 KB (+3.87% 🔺) 871 ms (+3.87% 🔺) 300 ms (+67.4% 🔺) 1.2 s
@lottiefiles/dotlottie-vue 47.12 KB (+3% 🔺) 943 ms (+3% 🔺) 276 ms (+35.98% 🔺) 1.3 s
@lottiefiles/dotlottie-wc 47.22 KB (+2.25% 🔺) 945 ms (+2.25% 🔺) 313 ms (-19.66% 🔽) 1.3 s
@lottiefiles/dotlottie-svelte 47.72 KB (+3.12% 🔺) 955 ms (+3.12% 🔺) 361 ms (+100.62% 🔺) 1.4 s
@lottiefiles/dotlottie-solid 46.6 KB (+3.23% 🔺) 932 ms (+3.23% 🔺) 268 ms (-16.03% 🔽) 1.2 s

@theashraf theashraf merged commit 40b19ef into main Sep 24, 2024
4 checks passed
@theashraf theashraf deleted the fix/webpack4-es2020 branch September 24, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants