Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): 🐛 fail to resize when canvas element is hidden #454

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

theashraf
Copy link
Member

@theashraf theashraf commented Jan 27, 2025

Description

fixes #260 #449

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This is something we need to do.

Copy link

changeset-bot bot commented Jan 27, 2025

🦋 Changeset detected

Latest commit: f7d420d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@lottiefiles/dotlottie-web Patch
@lottiefiles/dotlottie-react Patch
@lottiefiles/dotlottie-solid Patch
@lottiefiles/dotlottie-svelte Patch
@lottiefiles/dotlottie-vue Patch
@lottiefiles/dotlottie-wc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 27, 2025

Coverage Report for @lottiefiles/dotlottie-web (packages/web)

Status Category Percentage Covered / Total
🟢 Lines 53.25% (🎯 52%) 565 / 1061
🟢 Statements 52.11% (🎯 51%) 592 / 1136
🟢 Functions 52.38% (🎯 52%) 143 / 273
🟢 Branches 59.22% (🎯 58%) 398 / 672
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/web/src/dotlottie.ts 68.97% 65.71% 61.29% 72.13% 135-142, 165, 206-210, 245, 259, 274, 304, 327, 331, 408, 414, 430, 434, 469, 484-485, 500, 522-525, 558, 563, 573, 601-606, 610, 615-618, 625-639, 711-716, 720, 741, 776, 803-847, 851, 861-984, 1000-1071
packages/web/src/worker/dotlottie.ts 64.43% 65.42% 68.05% 68.35% 246, 264, 317, 325, 361, 385, 390, 397, 404-407, 411, 425-428, 432, 451, 470-483, 487, 494-497, 545-548, 559-562, 578, 585-591, 595, 622, 646-757
Generated in workflow #1639 for commit f7d420d by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Jan 27, 2025

Coverage Report for @lottiefiles/dotlottie-react (packages/react)

Status Category Percentage Covered / Total
🟢 Lines 97.46% (🎯 95%) 77 / 79
🟢 Statements 97.61% (🎯 95%) 82 / 84
🟢 Functions 100% (🎯 95%) 27 / 27
🟢 Branches 90% (🎯 89%) 45 / 50
File CoverageNo changed files found.
Generated in workflow #1639 for commit f7d420d by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Jan 27, 2025

Coverage Report for @lottiefiles/dotlottie-wc (packages/wc)

Status Category Percentage Covered / Total
🟢 Lines 98.46% (🎯 98%) 64 / 65
🟢 Statements 98.52% (🎯 98%) 67 / 68
🟢 Functions 100% (🎯 100%) 10 / 10
🟢 Branches 94.64% (🎯 94%) 53 / 56
File CoverageNo changed files found.
Generated in workflow #1639 for commit f7d420d by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Jan 27, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
@lottiefiles/dotlottie-web 38.08 KB (-0.02% 🔽) 762 ms (-0.02% 🔽) 184 ms (-14.15% 🔽) 946 ms
@lottiefiles/dotlottie-web WASM 400.27 KB (0%) 8.1 s (0%) 0 ms (+100% 🔺) 8.1 s
@lottiefiles/dotlottie-react 40.99 KB (+0.06% 🔺) 820 ms (+0.06% 🔺) 170 ms (+26.13% 🔺) 989 ms
@lottiefiles/dotlottie-vue 45.01 KB (+0.05% 🔺) 901 ms (+0.05% 🔺) 183 ms (-13.76% 🔽) 1.1 s
@lottiefiles/dotlottie-wc 45.44 KB (+0.11% 🔺) 909 ms (+0.11% 🔺) 345 ms (+79.43% 🔺) 1.3 s
@lottiefiles/dotlottie-svelte 45.57 KB (+0.07% 🔺) 912 ms (+0.07% 🔺) 183 ms (+58.56% 🔺) 1.1 s
@lottiefiles/dotlottie-solid 44.45 KB (+0.15% 🔺) 890 ms (+0.15% 🔺) 144 ms (+6.06% 🔺) 1.1 s

@theashraf theashraf self-assigned this Jan 27, 2025
@theashraf theashraf merged commit 5b6ec2f into main Jan 27, 2025
7 checks passed
@theashraf theashraf deleted the fix/invalid-img-width branch January 27, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to construct 'ImageData': The source width is zero or not a number.
2 participants