Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBD BMS - Support for a third temperature sensor #351

Closed
iLeeeZi opened this issue Dec 15, 2022 · 22 comments
Closed

JBD BMS - Support for a third temperature sensor #351

iLeeeZi opened this issue Dec 15, 2022 · 22 comments
Labels
enhancement New feature or request

Comments

@iLeeeZi
Copy link

iLeeeZi commented Dec 15, 2022

I have a JBD-SP04S034 4S 200A bms and there is three temperature sensors, one internal and two external. Currently the driver uses only first two temperatures which are one internal and one external in my setup.

I did some testing and lltjbd.py seems to read the data correctly for all sensors but there is no calculations for self.temp3 in battery.py

@Louisvdw Louisvdw added the enhancement New feature or request label Dec 29, 2022
@mr-manuel
Copy link
Collaborator

Same thing for JK-BMS. Is it correct, that in Venus OS we see only one temperature?

@vincegod
Copy link
Contributor

This is something I have noticed too and as the temperature is an average on the internal sensor and first external sensor it skews the battery temperature giving a higher value.

I was thinking of seeing if I can make this configurable so you can pick the sensors to use.

@mr-manuel
Copy link
Collaborator

Would it be possible, somehow, to display the temperatures like the cell voltages?

grafik

Obviously without Sum

@mr-manuel
Copy link
Collaborator

#440 adds the MOSFET temperature. So you have one external temperature sensor in Minimum cell temperature and the other external in Maximum cell temperature. Unfortunately you cannot difference which external temperature is linked to which external sensor.

@flyer9999
Copy link

I also stumbled across this problem today and would like to follow up here again. My BMS is a JBD/AP21S002, the first sensor (Temp-1) is internal for the BMS, NTC2 (Temp-2) and NTC3 (Temp-3), which are connected externally to the batteries. Temp-1 and Temp-2 are currently being calculated, but this does not reflect the actual temperature in the cells..
This then also distorts the settings for "TEMPERATURE_LIMITS_WHILE_CHARGING" and "TEMPERATURE_LIMITS_WHILE_DISCHARGING" in 'utils.py'.
Shouldn't a simple setting in the 'utils.py' of the TempSensors be possible? For example. "Temp-1" -> n.a./BMS ; "Temp-2" n.a./Battery ; "Temp-3" n.a./Battery

DRIVER_VERSION = 0.14
DRIVER_SUBVERSION = '.3'
BMS = JBD/AP21S002 21S 200A
venusOS on Raspberry Pi3 Model B V1.2 = v2.94

@pos-ei-don
Copy link

Using the mqtt driver from Manuel you can use any temp sensor and sent its value to the virtual mqtt-bms.

@mr-manuel
Copy link
Collaborator

Shouldn't a simple setting in the 'utils.py' of the TempSensors be possible? For example. "Temp-1" -> n.a./BMS ; "Temp-2" n.a./Battery ; "Temp-3" n.a./Battery

In my eyes this would complicate things a lot more. What do you understand under external sensors?

  1. Only BMS hardware external, but battery internal
  2. BMS and battery external
  3. Maybe even other...

One solution could be to change the driver of the JBD to display the Temp-1 as MOS Temperature and the other two as cell temperatures. What do you think?

@flyer9999
Copy link

One solution could be to change the driver of the JBD to display the Temp-1 as MOS Temperature and the other two as cell temperatures. What do you think?

Yes, perfect, that is what i mean. The "external" Sensors you can plug in and with these you go to the cells, these are Temp2 and Temp3. The Temp1 is the MOS/internal Temperature.

@mr-manuel mr-manuel changed the title Support for a third temperature sensor JBD BMS - Support for a third temperature sensor Apr 16, 2023
@mr-manuel
Copy link
Collaborator

mr-manuel commented Apr 16, 2023

Could you try this file and check the log after some minutes? There should appear some informations.

To try it, you need first to install the jkbms_ble branch, check if it's working and if yes then swap the file.

lltjbd.zip

@flyer9999

This comment was marked as resolved.

@mr-manuel

This comment was marked as resolved.

@flyer9999

This comment was marked as resolved.

@mr-manuel

This comment was marked as resolved.

@flyer9999

This comment was marked as resolved.

@mr-manuel

This comment was marked as resolved.

@mr-manuel
Copy link
Collaborator

@flyer9999 now I found the error and fixed it. A function name was wrong.

Thank you for all the testing. Uninstalling is not neccessary, if you are "updating" the driver. A reboot is anyway recomended.

Now it should run without errors, I tested it on a fresh system. Please redo this steps:

And now i run your script
wget -O /tmp/install-nightly.sh https://raw.githubusercontent.com/Louisvdw/dbus-serialbattery/jkbms_ble/etc/dbus-serialbattery/install-nightly.sh && bash /tmp/install-nightly.sh

and changed the lltjbd.py

@flyer9999
Copy link

flyer9999 commented Apr 19, 2023

Good Evening Manuel,
Beginning of another attempt :-)

Ohh Haa, in under 1 Minute everything is done and the Result is: It works !!!
image

image

image

image

However, what is still noticeable is that the log file is being shot up ...
Logfile: dbus-serialbattery.ttyACM0

@40000000644066ec33dd88d4 *** CCGX booted (0) ***
@400000006440670520036194 INFO:SerialBattery:Starting dbus-serialbattery
@4000000064406705200380d4 INFO:SerialBattery:dbus-serialbattery v1.0.0-jkbms_ble (20230419)
@400000006440670520039074 INFO:SerialBattery:Testing LltJbd
@4000000064406705271cbbc4 INFO:SerialBattery:Connection established to LltJbd
@40000000644067052728d954 INFO:SerialBattery:Battery LLT/JBD connected to dbus from /dev/ttyACM0
@40000000644067052730c4ac INFO:SerialBattery:========== Settings ==========
@4000000064406705273a0bac INFO:SerialBattery:> Connection voltage: NoneV | Current: NoneA | SoC: None%
@4000000064406705274189a4 INFO:SerialBattery:> Cell count: None | Cells populated: 0
@400000006440670527b7c72c INFO:SerialBattery:> LINEAR LIMITATION ENABLE: False
@400000006440670527b7e284 INFO:SerialBattery:> MAX BATTERY CHARGE CURRENT: 70.0V | MAX BATTERY DISCHARGE CURRENT: {utils.MAX_BATTERY_DISCHARGE_CURRENT}V
@400000006440670527b7fddc INFO:SerialBattery:> CVCM:     False
@400000006440670527b805ac INFO:SerialBattery:> MIN CELL VOLTAGE: 2.9V | MAX CELL VOLTAGE: 3.45V
@400000006440670527b81934 INFO:SerialBattery:> CCCM CV:  True  | DCCM CV:  True
@400000006440670527b824ec INFO:SerialBattery:> CCCM T:   True  | DCCM T:   True
@400000006440670527b9af74 INFO:SerialBattery:> CCCM SOC: False | DCCM SOC: False
@40000000644067052e9c2eac INFO:SerialBattery:DeviceInstance = 1
@40000000644067052ea54e9c INFO:SerialBattery:com.victronenergy.battery.ttyACM0
@400000006440670535ea21b4 ERROR:SerialBattery:type: <class 'int'>
@40000000644067053901122c INFO:SerialBattery:publish config values = 1
@40000000644067070712c88c ERROR:SerialBattery:type: <class 'int'>
@400000006440670808f55f84 ERROR:SerialBattery:type: <class 'int'>
@40000000644067090ab24ddc ERROR:SerialBattery:type: <class 'int'>
@400000006440670a0af93e04 ERROR:SerialBattery:type: <class 'int'>
@400000006440670b09cd4cdc ERROR:SerialBattery:type: <class 'int'>
@400000006440670c0b6eac84 ERROR:SerialBattery:type: <class 'int'>
@400000006440670d09e7742c ERROR:SerialBattery:type: <class 'int'>

@mr-manuel
Copy link
Collaborator

However, what is still noticeable is that the log file is being shot up ...

Yes since it publishes some debug output because I was not sure, what type the variable was. Could you warm up the external temperature sensors to make sure that the assignment is correct?

@flyer9999
Copy link

I just tried it, it works!
Temp-1 correct, Temp-2 correct and Temp-3 correct..

mr-manuel added a commit to mr-manuel/venus-os_dbus-serialbattery that referenced this issue Apr 20, 2023
mr-manuel added a commit to mr-manuel/venus-os_dbus-serialbattery that referenced this issue Apr 20, 2023
mr-manuel added a commit that referenced this issue Apr 20, 2023
@mr-manuel
Copy link
Collaborator

Thanks. The fix was merged with the jkbms_ble branch. The PR for the master branch will be merged mid May.

Louisvdw pushed a commit that referenced this issue May 6, 2023
* added balancing switch status

* added balancing switch status

* changed default config file
- added missing descriptions
- changed name

* indentation was wrong

* adding fix for Venus OS >= v3.00~14 QML files

* added cell balancing status for JKBMS

* changed ConsumedAmpHours
should be None instead of 0, if not available

* TimeToSoc fixes
- Added: Show TimeToSoc only, if enabled
- Changed: description in config file
- Changed: default value TIME_TO_SOC_VALUE_TYPE = 1

* resorted functions

* fix CPU overload
- changed: how often Time-To-Soc is calculated in seconds

* fix Time-to-Go and Time-to-SoC
- changed: Time-To-Go has to be always a positive int
since it's used from dbus-systemcalc-py
- changed: how Time-to-SoC is string is generated and displayed
(format like Time-To-Go)

* small fixes

* Show MOSFET temperature from JKBMS
Pull request from @baphomett
#440

* bump version to 1.0.0
respecting semantic versioning

* added uninstall script and fixed reinstall
- `/data/conf/serial-starter.d` was not recreated if deleted

* small fixes
- added description in utils.py
- change qml files in destination not source

* typo

* fixed cell balancing color for cells 13-24

* updated description in default config file

* Updated logging to get relevant informations

* clearer config file

* make config file clearer

* fix #421
- #421

* missing removals

* corrected typo, added missing +x in release.yml

* added info for new issue

* fix black lint errors

* optimize installation scripts

* added script to install directly from repository

* fixed serial-starter.d
#520

* smaller fixes

* fix #351

* fix System Switch in IO page

* fix #239
by @TimGFoley

* fix black lint errors

* run code analyse only on code change

* fix #311

* Separate Time-To-Go and Time-To-SoC activation

* remove duplicated and incorrect log message on handle_changed_setting

* properly log max battery currents on startup

* optimize uninstall script

* fix typo in log_settings

* add charge mode display

* Added: Temp name for sensor 1 & 2
Added the possibility to give a name to temperature sensor 1 & 2
This allows to see which sensor is low and high

* Added: Choose how battery temperature is assembled

* fix black lint errors

* Added/Changed alarms for JKBMS
* Added: HighInternalTemperature alarm for JKBMS
* Changed: Temperature alarm to not trigger all in the same condition

* Removed Alarms/HighCellVoltage
It does not exist on the dbus

* Changed: Moved charge mode
from IO page to Paramaters page

* Merge branch 'master' into master

* Added: Show (dis)charge current limitation reason

* Added changelog

* corrected file permissions

* Update readme

* Small word case changes

* fix dbus-daemon memory leak

`poll_battery` is already called from the dbus mainloop in a separate thread. Opening a new thread here (and especially never closing it) will accumulate threads and leads to problems like `dbus-daemon` memory usage increasing over time, leading to eventual reboot
by @seidler2547

* Added: Show specific TimeToSoC points in GUI
Only if 0%, 10%, 20%, 80%, 90% and/or 100% are selected

* fix black lint error

* removed wildcard import, fixed black lint errors

* removed wildcard import, fixed black lint errors

* remove old log message in handle_changed_setting()

* simplified condition for Time-To-Go/Soc

* fix renogy import

* added BMS info and cleanup
* MNB
* Revov
* Sinowealth

* moved BMS to subfolder

* Added self.unique_identifier to the battery class
Used to identify a BMS when multiple BMS are connected
planned for future use

* fix small errors

* added linear voltage recalculation interval
In the config file can now be defined how often CVL, CCL and DCL is recalculated

* revert Daly adaption

* replaced penalty voltage calculation
with automatically calculated penalty voltages to simplify config
max voltage is kept until batteries are balanced

* flake config change

* updated changelog

* disabled ANT BMS by default
#479

* fix typo

* fixed wrong variable assignment
`str` instead of `int`

* updated battery template

* updated nightly script

* Fix for #450
#450

* Read charge/discharge limit JKBMS
#4

* updated release workflow

* updated readme

* deploy to github pages only
on changes in master or docusaurus branch

* cleanup

* GitHub pages config change

* Renamed scripts for better reading #532

* update docusaurus dependencies

* limitation reason cleanup

* changed default config settings
FLOAT_CELL_VOLTAGE from 3.350V to 3.375V
LINEAR_LIMITATION_ENABLE from False to True

* small typo fixes

* updated changelog

* fix disconnection behaviour & small fixes
* on disconnect, show '---' after 10s and 'not connected' after 60s by @transistorgit
* small fixes in shell script
* added restart driver script

* fixed file permission

* Added: apply max voltage if CVCM_ENABLE is False
before float voltage was applied

* Added: BMS disconnect behaviour
* Choose to block charge/discharge on disconnect
* Trigger Venus OS alarm

* Changed: Remove wildcard import from dbushelper.py

* Added: Show additional data in device page
* show self.unique_identifier as serial number
* show self.production as device name

* Added: JKBMS unique identifier & fixed data length

* move config.ini before update

* read production date by @tranistorgit
this adds the battery production date

---------

Co-authored-by: Daniel Hillenbrand <daniel.hillenbrand@codeworkx.de>
Louisvdw pushed a commit that referenced this issue May 8, 2023
* added balancing switch status

* added balancing switch status

* changed default config file
- added missing descriptions
- changed name

* indentation was wrong

* adding fix for Venus OS >= v3.00~14 QML files

* added cell balancing status for JKBMS

* changed ConsumedAmpHours
should be None instead of 0, if not available

* TimeToSoc fixes
- Added: Show TimeToSoc only, if enabled
- Changed: description in config file
- Changed: default value TIME_TO_SOC_VALUE_TYPE = 1

* resorted functions

* fix CPU overload
- changed: how often Time-To-Soc is calculated in seconds

* fix Time-to-Go and Time-to-SoC
- changed: Time-To-Go has to be always a positive int
since it's used from dbus-systemcalc-py
- changed: how Time-to-SoC is string is generated and displayed
(format like Time-To-Go)

* small fixes

* Show MOSFET temperature from JKBMS
Pull request from @baphomett
#440

* bump version to 1.0.0
respecting semantic versioning

* added uninstall script and fixed reinstall
- `/data/conf/serial-starter.d` was not recreated if deleted

* small fixes
- added description in utils.py
- change qml files in destination not source

* typo

* fixed cell balancing color for cells 13-24

* updated description in default config file

* Updated logging to get relevant informations

* clearer config file

* make config file clearer

* fix #421
- #421

* missing removals

* corrected typo, added missing +x in release.yml

* added info for new issue

* fix black lint errors

* optimize installation scripts

* added script to install directly from repository

* fixed serial-starter.d
#520

* smaller fixes

* fix #351

* fix System Switch in IO page

* fix #239
by @TimGFoley

* fix black lint errors

* run code analyse only on code change

* fix #311

* Separate Time-To-Go and Time-To-SoC activation

* remove duplicated and incorrect log message on handle_changed_setting

* properly log max battery currents on startup

* optimize uninstall script

* fix typo in log_settings

* add charge mode display

* Added: Temp name for sensor 1 & 2
Added the possibility to give a name to temperature sensor 1 & 2
This allows to see which sensor is low and high

* Added: Choose how battery temperature is assembled

* fix black lint errors

* Added/Changed alarms for JKBMS
* Added: HighInternalTemperature alarm for JKBMS
* Changed: Temperature alarm to not trigger all in the same condition

* Removed Alarms/HighCellVoltage
It does not exist on the dbus

* Changed: Moved charge mode
from IO page to Paramaters page

* Merge branch 'master' into master

* Added: Show (dis)charge current limitation reason

* Added changelog

* corrected file permissions

* Update readme

* Small word case changes

* fix dbus-daemon memory leak

`poll_battery` is already called from the dbus mainloop in a separate thread. Opening a new thread here (and especially never closing it) will accumulate threads and leads to problems like `dbus-daemon` memory usage increasing over time, leading to eventual reboot
by @seidler2547

* Added: Show specific TimeToSoC points in GUI
Only if 0%, 10%, 20%, 80%, 90% and/or 100% are selected

* fix black lint error

* removed wildcard import, fixed black lint errors

* removed wildcard import, fixed black lint errors

* remove old log message in handle_changed_setting()

* simplified condition for Time-To-Go/Soc

* fix renogy import

* added BMS info and cleanup
* MNB
* Revov
* Sinowealth

* moved BMS to subfolder

* Added self.unique_identifier to the battery class
Used to identify a BMS when multiple BMS are connected
planned for future use

* fix small errors

* added linear voltage recalculation interval
In the config file can now be defined how often CVL, CCL and DCL is recalculated

* revert Daly adaption

* replaced penalty voltage calculation
with automatically calculated penalty voltages to simplify config
max voltage is kept until batteries are balanced

* flake config change

* updated changelog

* disabled ANT BMS by default
#479

* fix typo

* fixed wrong variable assignment
`str` instead of `int`

* updated battery template

* updated nightly script

* Fix for #450
#450

* Read charge/discharge limit JKBMS
#4

* updated release workflow

* updated readme

* deploy to github pages only
on changes in master or docusaurus branch

* cleanup

* GitHub pages config change

* Renamed scripts for better reading #532

* update docusaurus dependencies

* limitation reason cleanup

* changed default config settings
FLOAT_CELL_VOLTAGE from 3.350V to 3.375V
LINEAR_LIMITATION_ENABLE from False to True

* small typo fixes

* updated changelog

* fix disconnection behaviour & small fixes
* on disconnect, show '---' after 10s and 'not connected' after 60s by @transistorgit
* small fixes in shell script
* added restart driver script

* fixed file permission

* Added: apply max voltage if CVCM_ENABLE is False
before float voltage was applied

* Added: BMS disconnect behaviour
* Choose to block charge/discharge on disconnect
* Trigger Venus OS alarm

* Changed: Remove wildcard import from dbushelper.py

* Added: Show additional data in device page
* show self.unique_identifier as serial number
* show self.production as device name

* Added: JKBMS unique identifier & fixed data length

* move config.ini before update

* read production date by @tranistorgit
this adds the battery production date

* Changed: Merged all install files into one

* updated install docs for nightly build

* changed config backup

* changed release workflow

* changed release workflow

* changed release workflow

* optimized USB install method

* Daly improvements
* Set SoC on button press by @transistorgit
* Improved driver stability by @transistorgit & @mr-manuel

* moved production date and added custom field

---------

Co-authored-by: Daniel Hillenbrand <daniel.hillenbrand@codeworkx.de>
Louisvdw pushed a commit that referenced this issue May 8, 2023
* changed cell imbalance thresholds

* added battery details
- added: MOS temperature
- added: Balancing switch status

* JKBMS Bluetooth - added battery details (#454)

* added battery details
- added: capacity
- added: MOS temperature
- added: charging switch status
- added: discharging switch status
- added: balancing switch status
- added: show if balancing is active and which cells are balanced
- added: cell imbalance alert

* changed cell imbalance thresholds

* added battery details
- added: MOS temperature
- added: Balancing switch status

* added support for the newer 32s systems, that have slightly different frame-structure

* added stop of scraping if detection of jkbms fails

* lint

* indentation was wrong

* adding fix for Venus OS >= v3.00~14 QML files

* merge with baranator:dbus-serialbattery:master

* BLE JK BMS model recognition
Pull request from @tcrichton
#462

* Small fixes
- Added: Setup cronjob when installing driver
- Added: Information how to pair JKBMS changed default pin
- Changed: Bump version to v0.15.0-ble

* Added driver restart script

* added informations to run the driver

* pasted code in wrong function

* fixed cell balancing color

* BLE JK BMS model recognition (#462)

* * Other JK BMS’ have an underscore in their vendor_id
* Don’t forget to include your new PageLynxIonIo in the build lis

* build list is removed upstream

---------

Co-authored-by: Tristan Crichton <stan@tcrichton.co.uk>

* install BLE battery as local independent service

* add disconnect before starting the service

* unique id per BLE device

* enable logging and improve error messages

* Update jkbms_ble from master

* fixes

* moved ble part to installble.sh

* added script to install directly from repository

* added QML

* create empty config.ini for easier user usage

* optimize installation scripts

* changed bash output

* added post install notes

* corrected errors

* fix black lint errors

* fix black lint errors

* fix black lint errors

* bump version

* fixed serial-starter.d
#520

* fix errors, move install notes to show always

* Update install-nightly.sh

* Update install-nightly.sh

* make use of bluetooth configurable

* remove modules with uninstall script

* fix typo

* Added install notes

* fix #351

* fix System Switch in IO page

* fix #239
by @TimGFoley

* fix black lint errors

* run code analyse only on code change

* fix #311

* Separate Time-To-Go and Time-To-SoC activation

* fix UnicodeDecodeError
#485 (comment)

* fix UnicodeDecodeError
#485 (comment)

* optimize uninstall script

* fix typo in log_settings

* add charge mode display

* Added: Temp name for sensor 1 & 2
Added the possibility to give a name to temperature sensor 1 & 2
This allows to see which sensor is low and high

* Added: Choose how battery temperature is assembled

* Added/Changed alarms for JKBMS
* Added: HighInternalTemperature alarm for JKBMS
* Changed: Temperature alarm to not trigger all in the same condition

* Removed Alarms/HighCellVoltage
It does not exist on the dbus

* Changed: Moved charge mode
from IO page to Paramaters page

* Added: Show (dis)charge current limitation reason

* added changelog

* corrected file permissions

* fix dbus-daemon memory leak

`poll_battery` is already called from the dbus mainloop in a separate thread. Opening a new thread here (and especially never closing it) will accumulate threads and leads to problems like `dbus-daemon` memory usage increasing over time, leading to eventual reboot

* fix typo

* Update readme

* Remove bluetooth option from the config file
Bluetooth classes are now imported automatically, if it's a Bluetooth port

* Small word case changes

* Added: Show specific TimeToSoC points in GUI
Only if 0%, 10%, 20%, 80%, 90% and/or 100% are selected

* fix black lint error

* Improved JBD BMS soc calculation
#439

* Fix for #397
#484

* small fixes

* sort bms imports

* Add support for HLPdata BMS4S
#505

* Add support for Seplos BMS
#530

* change flake8 settings

* fix black lint errors

* removed wildcard imports

* fixed black lint errors

* change flake8 settings

* remove wildcard import and fix black lint errors

* removed wildcard import

* fixed black lint check

* config changes

* remove old log message in handle_changed_setting()

* simplified condition for Time-To-Go/Soc

* fix renogy import

* added BMS info and cleanup
* MNB
* Revov
* Sinowealth

* moved BMS to subfolder

* moved BMS to subfolder

* corrected installble to run correct script

* Added self.unique_identifier to the battery class
Used to identify a BMS when multiple BMS are connected
planned for future use

* changed ble service name
from `dbus-blebattery-$1` to `dbus-blebattery.$1` like the non ble service

* read installed capacity at startup

* disable ANT BMS by default
#479

* fix cell voltage header parser

* rework daly receive routine

* improve read cell voltages - only work on sufficient data, drop only the bad package on checksum error, not the complete transmission

* allow read_soc to also retry serial transmission

* add daly cell balance state info. cells are red only if unbalanced now

* bump version

* typo

* moved read_serialport_data() to daly.py

* revert read_serialport_data() to the state before my changes

* fix connection log startup message.
now voltage/current/soc are displayed correctly

* black reformatting

* flake config change

* added linear voltage recalculation interval
In the config file can now be defined how often CVL, CCL and DCL is recalculated

* replaced penalty voltage calculation
with automatically calculated penalty voltages to simplify config
max voltage is kept until batteries are balanced

* fix black lint errors

* updated config.default.ini

* update nightly install script

* Removed line

* fixed error in HLPdataBMS4S

* fixed wrong variable assignment
`str` instead of `int`

* updated battery template

* Fix for #450
#450

* Read charge/discharge limit JKBMS
#4

* updated battery template

* Progress with config limits reason

* updated CELL_VOLTAGE_DIFF_TO_RESET_VOLTAGE_LIMIT default value

* added SoC round for LLT/JBD

* fixed log typo

* reworked installation procedure
Bluetooth BMS is now also fetched from config.ini

* Merge branch 'master' into jkbms_ble

* Merge branch 'master' of into jkbms_ble

* GitHub pages config change

* cleanup

* Renamed scripts for better reading #532

* update docusaurus dependencies

* change sh with bash

* limitation reason cleanup

* changed default config settings
FLOAT_CELL_VOLTAGE from 3.350V to 3.375V
LINEAR_LIMITATION_ENABLE from False to True

* removed testing line

* Cleanup duplicated files

Files were moved and not deleted

* Cleanup

* MOSFET temperature was displayed twice after merge

* updated changelog

* Small fixes

* fix disconnection behaviour: on disconnect, show '---' after 10s and 'not connected' after 60s

* fix flake errors

* small fix

* Added: apply max voltage if CVCM_ENABLE is False
before float voltage was applied

* fixed type error

* Added: BMS disconnect behaviour
* Choose to block charge/discharge on disconnect
* Trigger Venus OS alarm

* Changed: Remove wildcard import from dbushelper.py

* small fixes

* flake8 changes

* copied lltjbd_ble from idstein:jdb_ble

* Added and adapted LltJbd_Ble
ATTENTION: Currently it's untested

* small changes

* read production date and append to hardware version

* Set SOC nightly. Button is working, next is send command to bms

* Added: Show additional data in device page
* show self.unique_identifier as serial number
* show self.production as device name

* Added: JKBMS unique identifier & fixed data length

* Added: JKBMS BLE unique identifier

* Added: Jkbms_Ble connection_name()

* Added: Daly unique identifier

* Added: JKBMS BLE serial number, user defined field

* read out daly battery code and use as unique id

* moved production date and added custom field

* clean battery code
strip whitespace and replace one or multiple spaces with one underline
if no battery code generate unique field

* Daly read_capacity change
Read capacity from config file, if no value provided by BMS

* Daly try to fix no reply

* Improvements by @transistorgit

* changed value

* set SOC (and date time) on button press.

* fix battery code parser

* format fix

* format fix

* fix extra long serial timeouts
by calculating max time instead of loop counts

* Small fixes

* updated config file

* updated changelog

* debug daly

* changed release workflow

* Updated from master

* fix blank screen, debug daly

* make Reset SoC a spin box

* fix possible read_capacity problem

* Daly read_balance_state() add missing return

* Daly advanced troubleshooting

* Changed: Improved Daily stability by a lot

* fixes for disable and uninstall
service was not removed and if removed, it was recreated by the serial starter

* optimized USB install method

* updated changelog

* added missing qml to restore-gui.sh

* Improved uninstall

* make executable

* ready to merge with master

---------

Co-authored-by: Eike Baran <derbaranator@gmail.com>
Co-authored-by: Eike Baran <eikebaran89@gmail.com>
Co-authored-by: Tristan Crichton <github@tcrichton.co.uk>
Co-authored-by: Tristan Crichton <stan@tcrichton.co.uk>
Co-authored-by: Stefan Seidel <lkml@stefanseidel.info>
Co-authored-by: seidler2547 <github@stefanseidel.info>
Co-authored-by: Bernd Stahlbock <stahlbock@gmail.com>
Co-authored-by: Bernd <b.stahlbock@gmx.de>
@AlexdeKairos
Copy link

One solution could be to change the driver of the JBD to display the Temp-1 as MOS Temperature and the other two as cell temperatures. What do you think?

Yes, perfect, that is what i mean. The "external" Sensors you can plug in and with these you go to the cells, these are Temp2 and Temp3. The Temp1 is the MOS/internal Temperature.

Hi Guys,
Sorry, that's my first post here.
I have a pair of BLE JBD connected batteries. BasenGreen ones. In my particular setup with 1.0.20231117dev. My first and only temperature sensor is connected to battery cells and not MOSFET. So with Basen Green Batteries, this mod does not work properly.
How can I set the temperature sensor n1 connected to Cells and not to MOS?

Many thanks
Alex

@Louisvdw
Copy link
Owner

Louisvdw commented Jan 20, 2024

@AlexdeKairos at the moment the first temp is always used for the MOS and there is no setting to adjust this. But it should be possible to adjust the code to cater for a scenario like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants