Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOVE: love.filesystem.load should be treated like loadfile. #1785

Closed
MikuAuahDark opened this issue Dec 25, 2022 · 0 comments · Fixed by #1789
Closed

LOVE: love.filesystem.load should be treated like loadfile. #1785

MikuAuahDark opened this issue Dec 25, 2022 · 0 comments · Fixed by #1789

Comments

@MikuAuahDark
Copy link

MikuAuahDark commented Dec 25, 2022 •
edited
Loading

I have a suggestion, hence the blank issue. When user set their environment as LOVE, love.filesystem.load should be added as loadfile equivalent in Lua.runtime.special in VS code.

Thank you for this awesome plugin, people who used it in LOVE Discord have good feedback with this plugin.

EDIT: Oh for additional context, in upcoming major LOVE version, we're adding 2nd parameter mode to love.filesystem.load which behaves same as mode parameter in Lua 5.3 load. Not sure how would Lua.runtime.special accomodate in that case though.
@C3pa C3pa mentioned this issue Dec 27, 2022
Merged
sumneko added a commit that referenced this issue Dec 29, 2022
@sumneko
Merge pull request #1789 from C3pa/implement-1785
46ac5d4 
Implement LOVE: love.filesystem.load should be treated like loadfile #1785
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement LOVE: love.filesystem.load should be treated like loadfile #1785 C3pa/lua-language-server
1 participant
@MikuAuahDark