Skip to content

Diagnostics run await.delay() too often #2665

@emmericp

Description

@emmericp

#2664 got a 25% speed increase by disabling await.delay() for the non-interactive use case.

Many diagnostics call await.delay() for every single ast node they check, so running all diagnostics on a file will probably reschedule the thread more than once per node which is a significant overhead.

I guess fully removing it for the interactive use case isn't a great solution, but maybe there is some kind of middleground like only rescheduling only every n calls?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions