Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] All In One Releases #849

Closed
0x0D15 opened this issue Dec 7, 2021 · 3 comments · Fixed by #850
Closed

[Feature Request] All In One Releases #849

0x0D15 opened this issue Dec 7, 2021 · 3 comments · Fixed by #850
Assignees

Comments

@0x0D15
Copy link

0x0D15 commented Dec 7, 2021

Currently it seems that users of this lsp have two options when installing/updating: cloning the repo and compiling from source, or cloning the repo and placing the corresponding binaries from github actions in the bin/<platform>/ folder. Would it be possible to remove the cloning step from this process entirely and either ship the required files alongside the binary in github actions or post releases on the github releases page with the corresponding version of the required files included?

This would make the installation/updating process significantly simpler as one can just download a zip, extract, and run. Thanks for considering.

@clason
Copy link

clason commented Dec 7, 2021

That is certainly possible in principle, but the issue is that there is no release workflow currently -- the binaries are purely a by-product of the CI testing.

I'm sure a PR adding such a release workflow would be appreciated!

@sumneko
Copy link
Collaborator

sumneko commented Dec 7, 2021

@actboy168 help!

@clason
Copy link

clason commented Dec 7, 2021

Basically, a release workflow should

  1. compile the binary on the corresponding platform (using the already available action)
  2. create a build subdirectory
  3. create bin/<platform> subdirectories under build
  4. copy lua-language-server and main.lua from bin/<platform> to build/bin/<platform>
  5. copy (recursively) main.lua, debugger.lua, locale, meta, and script to build
  6. zip the build directory
  7. create a release and upload the archive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants