feat(ci): publish platform specific binaries

[numToStr]

Summary of changes:

• Now platform-specific artifacts will be uploaded on each run
• Once a tag is released then it will populate the releases page with platform-specific assets. See https://github.com/numToStr/lua-language-server/releases

---

Some questions I have

• Platform suffix in the build path (ie. bin/{Linux,Windows,macOS}) bothers me a little as this is also reflected inside the release assets. Also, IMO these are kinda redundant now. So, Are you ok with removing the suffix? So that assets could just have binary w/o any directories.

-- Current
"bin/Linux" -- Bin dir
"lua-language-server-linux/linux/lua-language-server" -- inside asset
--     ^                     ^
-- asset name         platform suffix    

-- Wanted
"bin" -- bin dir
"lua-language-server-linux/lua-language-server" -- asset
-- or
"lua-language-server-linux/bin/lua-language-server" -- alternative structure

• We can probably merge this https://github.com/sumneko/lua-language-server/blob/master/.github/workflows/checkPR.yml workflow inside build workflow. What do you think? Done ;)

Closes #849

[numToStr]

I think I might also need to update the wiki :)

[clason]

Note that the binaries are not enough to have a functional installation; you also need the runtime scripts: #849 (comment)

[clason]

And +1 on flattening the hierarchy for the binary; that would make packaging for Homebrew easier!

[numToStr]

5. copy (recursively) main.lua, debugger.lua, locale, meta, and script to build

@clason Are you talking about this?

[clason]

yes

[numToStr]

Ok. I'll give it a shot.

[clason]

Also, a standard archive with the full (including submodules) sources for each release would be nice for Homebrew ;)

[numToStr]

Isn't the source zip automatically uploaded in the release?

[clason]

I don't think that includes the submodules? At least it doesn't for the tags.

(Not at all a dealbreaker, but if that's an easy add to your action, it'd be nice.)

[numToStr]

I don't think that includes the submodules? At least it doesn't for the tags.

Just checked. It doesn't even have the .git folder XD

(Not at all a dealbreaker, but if that's an easy add to your action, it'd be nice.)

I suppose I could do that :)

[clason]

I don't want the .git folder, just the pulled dependencies ;)

[numToStr]

I don't want the .git folder, just the pulled dependencies ;)

Got it. I'll probably tackle this tomorrow :p

[actboy168]

Platform suffix in the build path (ie. bin/{Linux,Windows,macOS}) bothers me a little as this is also reflected inside the release assets. Also, IMO these are kinda redundant now. So, Are you ok with removing the suffix? So that assets could just have binary w/o any directories.

I guess the bin directory contains platform suffix, because the release version of VSCode needs to contain all platform binaries.

But VSCode already supports platform specific extension. If lua-language-server can support this feature, it will no longer be necessary to include multiple platform binaries in one release.

[numToStr]

If lua-language-server can support this feature, it will no longer be necessary to include multiple platform binaries in one release.

Yes, the goal is to release platform specific binary packages so that anyone can play with lua-server as quickly as possible.

But VSCode already supports platform specific extension.

I don't know anything about vscode extensions but if it supports platform specific extensions then we are in good position.

[sumneko]

I will try to modify the VSCode release process and remove the <platform> folder

[numToStr]

@sumneko Should I remove the <platform> folder here? I suppose this is the line https://github.com/sumneko/lua-language-server/blob/247377652b61fd21f0a16ff8fd15bc8c54e3e080/make.lua#L5

[sumneko]

@sumneko Should I remove the <platform> folder here? I suppose this is the line

https://github.com/sumneko/lua-language-server/blob/247377652b61fd21f0a16ff8fd15bc8c54e3e080/make.lua#L5

There are still some problems with modifying the directory structure, we need to keep it unchanged first.

[numToStr]

@clason I've added the runtime files inside the release assets and also added the tagged version in the assets name. See https://github.com/numToStr/lua-language-server/releases/tag/0.0.0-pre.9

[numToStr]

There are still some problems with modifying the directory structure, we need to keep it unchanged first.

@sumneko Understood. I'll let you update the directory structure :)

[numToStr]

Now the submodules asset is also ready :) https://github.com/numToStr/lua-language-server/releases/tag/0.0.0-pre.12

[sumneko]

Which version do you want to revert to? ./bin/Linux/lua-language-server or ./Linux/lua-language-server or other?

[numToStr]

Which version do you want to revert to? ./bin/Linux/lua-language-server or ./Linux/lua-language-server or other?

To this ./bin/Linux/lua-language-server as It was before. Thanks :)

[sumneko]

It should be reverted.

[numToStr]

Thanks, @sumneko. I'll quickly rebase my PR.

[numToStr]

@sumneko I think I am finished with this PR. You can check the latest run and release assets

[sumneko]

What is submodules.zip ?

[numToStr]

What is submodules.zip?

This contains all the submodules sources for homebrew.

[sumneko]

I think the ./build folder should be excluded

[numToStr]

Done.

[sumneko]

./log should also be excluded.
I still not understand why it is needed, the ./3rd/lovr-api is so large

[numToStr]

./log should also be excluded. I still not understand why it is needed, the ./3rd/lovr-api is so large

@clason asked me for the submodule asset for homebrew distribution. I could remove it if you want.

[sumneko]

./log should also be excluded. I still not understand why it is needed, the ./3rd/lovr-api is so large

@clason asked me for the submodule asset for homebrew distribution. I could remove it if you want.

I used to think of homebrew as darwin, although they didn't look same at all.
If it is necessary for package management, there is no problem (I am not paying for the file size and bandwidth anyway)

[sumneko]

It seems good, thank you!

[clason]

./log should also be excluded. I still not understand why it is needed, the ./3rd/lovr-api is so large

@clason asked me for the submodule asset for homebrew distribution. I could remove it if you want.

I used to think of homebrew as darwin, although they didn't look same at all. If it is necessary for package management, there is no problem (I am not paying for the file size and bandwidth anyway)

I just need the 3rd/luamake and 3rd/bee subdirectories for building. The idea is to be able to just download the release and call luamake rebuild without needing a git submodule init update.

I used to think of homebrew as darwin, although they didn't look same at all.
If it is necessary for package management, there is no problem (I am not paying for the file size and bandwidth anyway)

Homebrew used to be macOS only, but they have joined with the linuxbrew project, so now they build everything for macOS and Linux from the same formula (hence needing to distinguish the platforms there).

[clason]

To make clear, it would simplify the homebrew formula if the v2.6.0.tar.gz release tarball included the submodules needed for building it, but it is not necessary (homebrew can clone a repo and update submodules as part of the build pipeline, like it does for the current formula I submitted). So if that is at all awkward to do here, just don't worry about including submodules.