Skip to content

fix: default severity in CLI with partial 'diagnostics.severity' config #2731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2024
Merged

fix: default severity in CLI with partial 'diagnostics.severity' config #2731

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
917bdfe
fix: default severity in CLI with partial 'diagnostics.severity' config
tomlau10 Jun 26, 2024
6507b8a
Merge branch 'master' into bugfix/cli_default_severity
sumneko Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Unreleased
<!-- Add all new changes here. They will be moved under a version at release -->
* `NEW` Add postfix snippet for `unpack`
* `FIX` `diagnostics.severity` defaulting to "Warning" when run using `--check` [#2730](https://github.com/LuaLS/lua-language-server/issues/2730)

## 3.9.3
`2024-6-11`
Expand Down
2 changes: 1 addition & 1 deletion script/cli/check_worker.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ xpcall(lclient.start, errorhandler, lclient, function (client)

local disables = util.arrayToHash(config.get(rootUri, 'Lua.diagnostics.disable'))
for name, serverity in pairs(define.DiagnosticDefaultSeverity) do
serverity = config.get(rootUri, 'Lua.diagnostics.severity')[name] or 'Warning'
serverity = config.get(rootUri, 'Lua.diagnostics.severity')[name] or serverity
if serverity:sub(-1) == '!' then
serverity = serverity:sub(1, -2)
end
Expand Down