Storage fspath #156
Merged
Storage fspath #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsakiller
added
bug
carsakiller
force-pushed
the
storage-fspath
branch
from
9bdfd05
to
734c24b
Compare
carsakiller
force-pushed
the
storage-fspath
branch
from
734c24b
to
03919a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issues with
${addons}not being resolved properly. I believe it was due toURI.pathalways returning a unix-like path/c/Users/Me..., even on Windows.URI.fsPathshould return a more suitable path given the host OS.Related server PR: LuaLS/lua-language-server#2913