Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Profile): display Toast when saving note #503

Merged

Conversation

FineFindus
Copy link

It can be quite unclear if the note has been saved. This adds a toast, to indicate that the profile note has been saved.

On a sidenote, saving currently does not work when pressing the back button, though this should be solved when merging upstream.

The NoteEdit InputType is already set in the UI file.
It can be quite unclear if the note has been saved. This adds a toast,
to indicate that the profile note has been saved.
Copy link
Owner

@LucasGGamerM LucasGGamerM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought removing the else would break things, but you made an early return, so it should be fine.

@LucasGGamerM LucasGGamerM merged commit 13545fd into LucasGGamerM:master Aug 11, 2024
1 check passed
@FineFindus FineFindus deleted the feat/profile-note-save-feedback branch August 11, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants