fix(Profile) note save crash #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the global context for displaying the note saved toast. When using the local context, it was somehow, sometimes null, leading to crashes.
The note text field being hidden is already enough comfirmation that the note has been hidden.
Fixes an issue, where if the NoteTextField was focussed and the note was hidden, the note would saved and reshown once the NoteTextField was hidden.
LucasGGamerM
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue, where the context used for displaying the note saved toast could sometimes be null on actual device. I did not encounter this on the emulator. My best guess is that, since currently, the note is only saved once actually exiting the fragment, and not on back pressing, the fragment context has already been cleaned up.