feat(MuteSheet): revert to row #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially 6c519b3 to use the full row again, but keep the selection in a dialog. This improves the UI, as the secondary button is confusing, and feels out-of-place.
|
Can you send a screenshot of a before and after? |
|
Pretty much the same as in #371, but when clicking the button, the current time dialog opens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts 6c519b3 to use the full row again, but keeps the selection in a dialog. This improves the UI, as the secondary button is confusing, and feels out-of-place.
Also fixes an issue, where the selected duration would not be updated when re-opening the dialog.