Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds turbo instead turbolinks, updates rails to 6.1, adds animation f… #72

Merged
merged 2 commits into from
Apr 21, 2021

Conversation

LucasKuhn
Copy link
Owner

…or like button, animation to alerts, adds s3 to local task, remove adorable avatars

…or like button, animation to alerts, adds s3 to local task, remove adorable avatars
@LucasKuhn LucasKuhn temporarily deployed to recomendo-pi-turbo-sc7vlvi8fdg March 17, 2021 00:02 Inactive
@LucasKuhn LucasKuhn temporarily deployed to recomendo-pi-turbo-sc7vlvi8fdg March 17, 2021 00:03 Inactive
@LucasKuhn LucasKuhn self-assigned this Apr 4, 2021
Copy link
Owner Author

@LucasKuhn LucasKuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor tweaks needed

@@ -44,11 +46,11 @@
# config.action_cable.allowed_request_origins = [ 'http://example.com', /http:\/\/example.*/ ]

# Force all access to the app over SSL, use Strict-Transport-Security, and use secure cookies.
config.force_ssl = true
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why comment this out

Comment on lines +1 to +11
# Define an application-wide HTTP permissions policy. For further
# information see https://developers.google.com/web/updates/2018/06/feature-policy
#
# Rails.application.config.permissions_policy do |f|
# f.camera :none
# f.gyroscope :none
# f.microphone :none
# f.usb :none
# f.fullscreen :self
# f.payment :self, "https://secure.example.com"
# end
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool


task :s3_to_local do

s3_bucket = "recomendoapp"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be a secret coming from an ENV also

@LucasKuhn LucasKuhn merged commit e550539 into master Apr 21, 2021
@LucasKuhn
Copy link
Owner Author

Fixes #68

@LucasKuhn
Copy link
Owner Author

closes #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant