Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trim option to command chains #153

Closed
LucasPickering opened this issue Apr 16, 2024 · 1 comment · Fixed by #197
Closed

Add trim option to command chains #153

LucasPickering opened this issue Apr 16, 2024 · 1 comment · Fixed by #197
Assignees
Labels
good first issue Good for newcomers qol Improvements that make usage smoother, without introducing new functionality

Comments

@LucasPickering
Copy link
Owner

LucasPickering commented Apr 16, 2024

Add a field trim to the command chain source, which trims whitespace from the ends of the output string. It's pretty common to have shell commands that include a useless trailing newline, in which case you have to do something like command: [sh, -c, "<cmd> | tr -d '\n'"]

Worth considering: instead of just a boolean, should just be an enum? none, start, end, both?

Implementation

@LucasPickering LucasPickering added qol Improvements that make usage smoother, without introducing new functionality good first issue Good for newcomers labels Apr 16, 2024
@Sammo98
Copy link
Contributor

Sammo98 commented Apr 29, 2024

@LucasPickering I'd be keen to pick this one up as well, unless anyone else had plans to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers qol Improvements that make usage smoother, without introducing new functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants