Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest response doesn't show on first load #199

Closed
LucasPickering opened this issue May 1, 2024 · 0 comments · Fixed by #203
Closed

Latest response doesn't show on first load #199

LucasPickering opened this issue May 1, 2024 · 0 comments · Fixed by #203
Labels
bug Something isn't working

Comments

@LucasPickering
Copy link
Owner

Describe the bug
A clear and concise description of what the bug is

When you first start the TUI, the latest request/response for whatever recipe is selected doesn't show. Once you select a different recipe and go back, you'll see it there.

To Reproduce
Steps to reproduce the behavior

  1. Make a request for any recipe
  2. Make sure that recipe is selected in the TUI
  3. Exit the TUI and restart
  4. Confirm the Request and Response panes are empty

Expected behavior
A clear and concise description of what you expected to happen

Request/Response panes should show the last request/response.

Screenshots
If applicable, add screenshots to help explain your problem

image

Version (please complete the following information):

  • OS: macOS
  • Terminal: iterm2
  • Slumber Version: 1.0.1

Additional context
Add any other context about the problem here.

@LucasPickering LucasPickering added the bug Something isn't working label May 1, 2024
LucasPickering added a commit that referenced this issue May 3, 2024
Fix the latest request/response not showing up when the app is first started, or after a collection reload. This was only happening if the first recipe in the list was selected (index 0). The problem was we weren't calling on_select when the default value (0) was selected. When it was loaded from the DB it still wasn't pre-selected because it detected no change.

Fixed by adding a builder pattern so we can define on_select then call select_index in the constructor.

Closes #199
LucasPickering added a commit that referenced this issue May 3, 2024
Fix the latest request/response not showing up when the app is first started, or after a collection reload. This was only happening if the first recipe in the list was selected (index 0). The problem was we weren't calling on_select when the default value (0) was selected. When it was loaded from the DB it still wasn't pre-selected because it detected no change.

Fixed by adding a builder pattern so we can define on_select then call select_index in the constructor.

Closes #199
LucasPickering added a commit that referenced this issue May 4, 2024
Fix the latest request/response not showing up when the app is first started, or after a collection reload. This was only happening if the first recipe in the list was selected (index 0). The problem was we weren't calling on_select when the default value (0) was selected. When it was loaded from the DB it still wasn't pre-selected because it detected no change.

Fixed by adding a builder pattern so we can define on_select then call select_index in the constructor.

Closes #199
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue May 6, 2024
[1.1.0] - 2024-05-05

Added
- Add `section` field to `!request` chain values, to allow chaining response headers rather than body ([#184](LucasPickering/slumber#184))
- Add action to save response body to file ([#183](LucasPickering/slumber#183))
- Add `theme` field to the config, to configure colors ([#193](LucasPickering/slumber#193))
  - [See docs](https://slumber.lucaspickering.me/book/api/configuration/theme.html) for more info
- Add `stdin` option to command chains ([#190](LucasPickering/slumber#190))

Changed
- Reduce UI latency under certain scenarios
  - Previously some actions would feel laggy because of an inherent 250ms delay in processing some events
- Search parent directories for collection file ([#194](LucasPickering/slumber#194))
- Use thicker borders for selected pane and modals
- Change default TUI colors to blue and yellow

Fixed
- Fix Slumber going into zombie mode and CPU spiking to 100% under certain closure scenarios ([#136](LucasPickering/slumber#136))
- Fix historical request/response no loading on first render ([#199](LucasPickering/slumber#199))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant