Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search parent directories for collection file #195

Merged
merged 1 commit into from
May 1, 2024

Conversation

LucasPickering
Copy link
Owner

Description

Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.

  • If a collection file isn't found in the current directory, recursively search our parents (up to the fs root) to find it.
  • Print a notification on startup to show the loaded collection file (similar to what shows after a reload)
  • In dev mode, always use the crate root to locate data/ instead of the cwd

Closes #194

Known Risks

What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?

Could potentially be unexpected behavior. Mitigated via documentation.

QA

How did you test this?

  • cd src
  • cargo run
  • Confirm it loads the collection file and shows it in the parent
  • Confirm logs are written to data/log/slumber.log in the crate root, not src/data/...

Checklist

  • Have you read CONTRIBUTING.md already?
  • Did you update CHANGELOG.md?
    • Only user-facing changes belong in the changelog. Internal changes such as refactors should only be included if they'll impact users, e.g. via performance improvement.
  • Did you remove all TODOs?
    • If there are unresolved issues, please open a follow-on issue and link to it in a comment so future work can be tracked

- If a collection file isn't found in the current directory, recursively search our parents (up to the fs root) to find it.
- Print a notification on startup to show the loaded collection file (similar to what shows after a reload)

Closes #194
@LucasPickering LucasPickering merged commit 27644e7 into master May 1, 2024
14 checks passed
@LucasPickering LucasPickering deleted the detect-parent-file branch May 1, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: Improve Auto Detect slumber.yaml
1 participant