Move RequestStore to top level of TUI state #377
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.
This moves RequestStore out of the view and into root state. This means we can use it to track in flight requests. In the future we'll use it for cancellation tokens too.
Known Risks
What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?
I'm not particularly fond of this code, especially the Rc<RefCell<_>> in TestHarness. I'll probably clean it up eventually but right now I just need to make progress. So the risk is poor maintainability.
The
UpdateContext
is also a bit of a regression, since it existed in the past and I moved everything toViewContext
. I'm trying to avoid needingRc<RefCell<_>>
in theViewContext
(especially since it already wraps the whole context in a refcell). By passing values around throughout the course of a single frame, we can rely on regular ass borrowing rules.QA
How did you test this?
Existing test coverage is pretty good. Tested manually too.
Checklist
CONTRIBUTING.md
already?CHANGELOG.md
?