Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Option<Component<T>> with Component<Option<T>> #382

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

LucasPickering
Copy link
Owner

@LucasPickering LucasPickering commented Sep 16, 2024

Description

Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.

This makes code with optional data fields less clunky (hopefully). Specifically it eliminates the need for weird iter/option flattening in children impls, and if let guards for drawing optional data.

Known Risks

What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?

Code could potentially be harder to follow/more magical

QA

How did you test this?

Checklist

  • Have you read CONTRIBUTING.md already?
  • Did you update CHANGELOG.md?
    • Only user-facing changes belong in the changelog. Internal changes such as refactors should only be included if they'll impact users, e.g. via performance improvement.
  • Did you remove all TODOs?
    • If there are unresolved issues, please open a follow-on issue and link to it in a comment so future work can be tracked

This makes code with optional data fields less clunky (hopefully)
@LucasPickering LucasPickering enabled auto-merge (rebase) September 16, 2024 14:55
@LucasPickering LucasPickering merged commit 60e5692 into master Sep 16, 2024
15 checks passed
@LucasPickering LucasPickering deleted the component-option branch September 16, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant