Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debounce on query box #466

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Remove debounce on query box #466

merged 1 commit into from
Feb 3, 2025

Conversation

LucasPickering
Copy link
Owner

@LucasPickering LucasPickering commented Feb 3, 2025

Description

Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.

It's convenient in some scenarios, but with command-based filtering it ends up just being really annoying.

Known Risks

What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?

This does bring us back to it being more cumbersome to do repeated filters, since you have to keep hitting / to get back into the search box. We could mitigate this by adding a keybind to mean "submit but stay in focus", e.g. shift+enter.

QA

How did you test this?

Existing tests

Checklist

  • Have you read CONTRIBUTING.md already?
  • Did you update CHANGELOG.md?
    • Only user-facing changes belong in the changelog. Internal changes such as refactors should only be included if they'll impact users, e.g. via performance improvement.
  • Did you remove all TODOs?
    • If there are unresolved issues, please open a follow-on issue and link to it in a comment so future work can be tracked

It's convenient in some scenarios, but with command-based filtering it ends up just being really annoying.
@LucasPickering LucasPickering merged commit ed457e6 into master Feb 3, 2025
15 checks passed
@LucasPickering LucasPickering deleted the remove-debounce branch February 3, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant