Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix panic cleanup issues #471

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

LucasPickering
Copy link
Owner

@LucasPickering LucasPickering commented Feb 19, 2025

Description

Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.

I've noticed some issues with the app occasionally not cleaning up the terminal properly on exit. I've never been able to pin down why or reproduce it reliably, but this is a mild attempt at fixing it.

Known Risks

What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?

Still broken

QA

How did you test this?

I tested manual quitting a panics still clean up like normal, as far as I can tell

Checklist

  • Have you read CONTRIBUTING.md already?
  • Did you update CHANGELOG.md?
    • Only user-facing changes belong in the changelog. Internal changes such as refactors should only be included if they'll impact users, e.g. via performance improvement.
  • Did you remove all TODOs?
    • If there are unresolved issues, please open a follow-on issue and link to it in a comment so future work can be tracked

@LucasPickering LucasPickering enabled auto-merge (rebase) February 19, 2025 13:00
@LucasPickering LucasPickering merged commit 78b71c8 into master Feb 19, 2025
15 checks passed
@LucasPickering LucasPickering deleted the better-panic-cleanup branch February 19, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant